Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2470133005: MIPS[64]: Port '[turbofan] Use zr to store immediate zero' (Closed)

Created:
4 years, 1 month ago by dusan.simicic
Modified:
4 years, 1 month ago
Reviewers:
ivica.bogosavljevic, Benedikt Meurer, miran.karic
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Port '[turbofan] Use zr to store immediate zero' Port 0322c20d178db0b3360af0353972bc338b2d4b18 Original commit message: When storing an immediate integer or floating point zero, use the zero register as the source value. This avoids the need to sometimes allocate a new register. BUG= Committed: https://crrev.com/b725d5a79765451cb1869eb8021da633eaf1c02c Cr-Commit-Position: refs/heads/master@{#40987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -60 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 8 chunks +52 lines, -23 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 5 chunks +43 lines, -7 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 9 chunks +54 lines, -22 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 6 chunks +34 lines, -7 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 3 chunks +95 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 3 chunks +104 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
dusan.simicic
PTAL
4 years, 1 month ago (2016-11-04 10:31:52 UTC) #2
ivica.bogosavljevic
lgtm, but you will need to approval from the file instruction-selector-unittest.h owner
4 years, 1 month ago (2016-11-04 10:42:42 UTC) #4
ivica.bogosavljevic
Reminder!
4 years, 1 month ago (2016-11-14 08:41:29 UTC) #7
Benedikt Meurer
LGTM, sorry for the delay, missed this one.
4 years, 1 month ago (2016-11-15 05:16:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470133005/1
4 years, 1 month ago (2016-11-15 11:55:18 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 11:57:20 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:33:49 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b725d5a79765451cb1869eb8021da633eaf1c02c
Cr-Commit-Position: refs/heads/master@{#40987}

Powered by Google App Engine
This is Rietveld 408576698