Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 247013002: Replaced empty handle checks with MaybeHandles (Closed)

Created:
6 years, 8 months ago by mvstanton
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

JSObject::DeepCopy and other functions returned an empty handle to indicate an exception. All usages but one changed to return MaybeHandles, and to use macros around the call. The remaining work is in Compiler::GetUnoptimizedCode(), and when that is turned into a MaybeHandle, then the macros dealing with null handle returns can be eliminated. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20877

Patch Set 1 #

Patch Set 2 : More MaybeHandles. #

Total comments: 3

Patch Set 3 : Removed unnecessary assert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -89 lines) Patch
M src/api.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/isolate.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/jsregexp.h View 1 2 chunks +10 lines, -8 lines 0 comments Download
M src/jsregexp.cc View 1 2 4 chunks +12 lines, -16 lines 0 comments Download
M src/objects.h View 1 2 chunks +11 lines, -8 lines 0 comments Download
M src/objects.cc View 1 11 chunks +42 lines, -32 lines 0 comments Download
M src/runtime.cc View 1 7 chunks +21 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Hi Yang, PTAL, thx! --Michael https://codereview.chromium.org/247013002/diff/40001/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/247013002/diff/40001/src/runtime.cc#newcode14852 src/runtime.cc:14852: initial_map = Map::AsElementsKind(initial_map, to_kind); ...
6 years, 8 months ago (2014-04-22 09:15:10 UTC) #1
Yang
LGTM! https://codereview.chromium.org/247013002/diff/40001/src/jsregexp.cc File src/jsregexp.cc (right): https://codereview.chromium.org/247013002/diff/40001/src/jsregexp.cc#newcode347 src/jsregexp.cc:347: ASSERT(!last_match_info.is_null()); Kind of wonder why you have this. ...
6 years, 8 months ago (2014-04-22 09:27:19 UTC) #2
mvstanton
thanks very much, submitting... https://codereview.chromium.org/247013002/diff/40001/src/jsregexp.cc File src/jsregexp.cc (right): https://codereview.chromium.org/247013002/diff/40001/src/jsregexp.cc#newcode347 src/jsregexp.cc:347: ASSERT(!last_match_info.is_null()); On 2014/04/22 09:27:20, Yang ...
6 years, 8 months ago (2014-04-22 09:30:18 UTC) #3
mvstanton
6 years, 8 months ago (2014-04-22 09:32:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r20877 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698