Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2470073002: Revert of Add Resume logic of Purge+Suspend to TabManager. (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
Reviewers:
haraken, chrisha, tasak
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add Resume logic of Purge+Suspend to TabManager. (patchset #3 id:60001 of https://codereview.chromium.org/2462513002/ ) Reason for revert: Reliably breaks Linux ChromiumOS Tests (1): https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/28780 and Linux ChromiumOS Tests (dbg)(1): https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/19523 Original issue's description: > Add Resume logic of Purge+Suspend to TabManager. > > - To avoid breaking web, we need to resume a backgrounded renderer that > was purged and suspended. > (A backgrounded renderer is suspended for 120seconds). > After resumed, the renderer is running for 10 seconds and is purged > and suspended again. > - intent-to-implement-and-ship of background renderer's purge + > suspend is > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4 > - one of the documents attached in the above intent is > https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJvI/edit?usp=sharing > - The feature is not enabled by default because > purge-and-suspend-time is 0. > > BUG=635419 > > Committed: https://crrev.com/8241a62d2ba05a3c1d55d0e087986b637658892b > Cr-Commit-Position: refs/heads/master@{#429222} TBR=haraken@chromium.org,chrisha@chromium.org,tasak@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635419 Committed: https://crrev.com/5af515953863b831c317fdbc70b8254e1784bff7 Cr-Commit-Position: refs/heads/master@{#429237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -210 lines) Patch
M chrome/browser/memory/tab_manager.h View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/memory/tab_manager.cc View 5 chunks +11 lines, -80 lines 0 comments Download
M chrome/browser/memory/tab_manager_unittest.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M chrome/browser/memory/tab_manager_web_contents_data.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/memory/tab_manager_web_contents_data.cc View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/memory/tab_manager_web_contents_data_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
kjellander_chromium
Created Revert of Add Resume logic of Purge+Suspend to TabManager.
4 years, 1 month ago (2016-11-02 08:12:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470073002/1
4 years, 1 month ago (2016-11-02 08:12:49 UTC) #3
haraken
LGTM to revert.
4 years, 1 month ago (2016-11-02 08:13:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 08:13:52 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5af515953863b831c317fdbc70b8254e1784bff7 Cr-Commit-Position: refs/heads/master@{#429237}
4 years, 1 month ago (2016-11-02 08:15:47 UTC) #7
kjellander_chromium
On 2016/11/02 08:15:47, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 1 month ago (2016-11-02 08:22:42 UTC) #8
tasak
On 2016/11/02 08:22:42, kjellander_chromium wrote: > On 2016/11/02 08:15:47, commit-bot: I haz the power wrote: ...
4 years, 1 month ago (2016-11-02 09:09:49 UTC) #9
tasak
On 2016/11/02 09:09:49, tasak wrote: > On 2016/11/02 08:22:42, kjellander_chromium wrote: > > On 2016/11/02 ...
4 years, 1 month ago (2016-11-02 09:11:01 UTC) #10
tasak
4 years, 1 month ago (2016-11-02 09:21:45 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2471613003/ by tasak@google.com.

The reason for reverting is: Because the change added by the reverted patch is
not enabled by default.

.

Powered by Google App Engine
This is Rietveld 408576698