Move importModules function to util.js

Move importModules function to util.js

The importModules function is repeatedly defined in WebUI resources, so it has
been copied to the util.js file and the original definitions have been removed
from the WebUI resources.

util.js import has been included where it was needed.

BUG=652361
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/516d07c7386353cffbb0e7172fd8f3de5f61d069
Cr-Commit-Position: refs/heads/master@{#429411}

[mbrunson, 2016-11-02 17:50:44]

Description was changed from

==========
Move importModules function to util.js

The importModules function is repeatedly defined in WebUI resources, so it has
been copied to the util.js file and the original definitions have been removed
from the WebUI resources.

util.js import has been included where it was needed.

BUG=652361
==========

to

==========
Move importModules function to util.js

The importModules function is repeatedly defined in WebUI resources, so it has
been copied to the util.js file and the original definitions have been removed
from the WebUI resources.

util.js import has been included where it was needed.

BUG=652361
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[mbrunson, 2016-11-02 18:59:58]

mbrunson@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2016-11-02 19:21:07]

LGTM (assuming everything passes).

[mbrunson, 2016-11-02 19:22:05]

The CQ bit was checked by mbrunson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 19:22:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 19:34:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 19:34:09]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[mbrunson, 2016-11-02 19:57:56]

The CQ bit was checked by mbrunson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 19:58:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mbrunson, 2016-11-02 20:23:17]

On 2016/11/02 19:21:07, dpapad wrote:
> LGTM (assuming everything passes).

Closure compiler fails because "define" is undefined. I'm assuming this function
is only defined on pages that load Mojo interfaces or something?

I've added a "@suppress {undefinedVars}" to bypass that, but I'm sure there's a
better way.

Suggestions?

[dpapad, 2016-11-02 20:27:37]

+dbeam: Is there an externs file we could add the define() declaration, instead
of suppressing the error?

[Dan Beam, 2016-11-02 21:10:40]

On 2016/11/02 20:27:37, dpapad wrote:
> +dbeam: Is there an externs file we could add the define() declaration,
instead
> of suppressing the error?

probably but it doesn't matter to me much either way

[commit-bot: I haz the power, 2016-11-02 21:44:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 21:44:28]

Dry run: This issue passed the CQ dry run.

[mbrunson, 2016-11-02 21:45:35]

On 2016/11/02 21:10:40, Dan Beam wrote:
> On 2016/11/02 20:27:37, dpapad wrote:
> > +dbeam: Is there an externs file we could add the define() declaration,
> instead
> > of suppressing the error?
> 
> probably but it doesn't matter to me much either way

Alright. Well, I'll just leave it here for now. If a preference comes up later,
it can be moved again.

[mbrunson, 2016-11-02 21:45:44]

The CQ bit was checked by mbrunson@chromium.org

[mbrunson, 2016-11-02 21:45:44]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2470063003/#ps20001
(title: "Add suppress")

[commit-bot: I haz the power, 2016-11-02 21:46:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 21:51:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-02 21:53:43]

Description was changed from

==========
Move importModules function to util.js

The importModules function is repeatedly defined in WebUI resources, so it has
been copied to the util.js file and the original definitions have been removed
from the WebUI resources.

util.js import has been included where it was needed.

BUG=652361
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Move importModules function to util.js

The importModules function is repeatedly defined in WebUI resources, so it has
been copied to the util.js file and the original definitions have been removed
from the WebUI resources.

util.js import has been included where it was needed.

BUG=652361
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/516d07c7386353cffbb0e7172fd8f3de5f61d069
Cr-Commit-Position: refs/heads/master@{#429411}
==========

[commit-bot: I haz the power, 2016-11-02 21:53:44]

Patchset 2 (id:??) landed as
https://crrev.com/516d07c7386353cffbb0e7172fd8f3de5f61d069
Cr-Commit-Position: refs/heads/master@{#429411}