Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2470063002: X87: [compiler] Sanitize IC counts for vector based ICs. (Closed)

Created:
4 years, 1 month ago by zhengxing.li
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [compiler] Sanitize IC counts for vector based ICs. port 5ef1bddf80d176c3f882b699e65f48fba1af3da5 (r40690) original commit message: All vector ICs use the TypeFeedbackVector::ComputeCounts method now, while the remaining patching ICs still use the traditional way of counting on the TypeFeedbackInfo hanging off the fullcodegen code object. This fixes the problem that counts were sometimes off. BUG= Drive-by-fix: Move FullCodeGenerator::CallIC to fullcodegen.cc. Committed: https://crrev.com/3ef54ed6932457b67027941e34f359a3c50eb280 Cr-Commit-Position: refs/heads/master@{#40692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/x87/macro-assembler-x87.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 1 month ago (2016-11-02 06:59:36 UTC) #2
Weiliang
lgtm
4 years, 1 month ago (2016-11-02 07:25:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470063002/1
4 years, 1 month ago (2016-11-02 07:31:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 07:50:46 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ef54ed6932457b67027941e34f359a3c50eb280
Cr-Commit-Position: refs/heads/master@{#40692}

Powered by Google App Engine
This is Rietveld 408576698