Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2470043006: PPC/s390: [turbofan] Refactor the compare-zero folding in instruction selector. (Closed)

Created:
4 years, 1 month ago by yangtian.zi
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [turbofan] Refactor the compare-zero folding in instruction selector. Port 9b308dcaf5ce0597a2acfd85d7104ed263c472aa R=jarin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/bbab241ca1dc635b78293402b5877ce48784365c Cr-Commit-Position: refs/heads/master@{#40774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M src/compiler/ppc/instruction-selector-ppc.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 2 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
yangtian.zi
ptal
4 years, 1 month ago (2016-11-04 00:31:21 UTC) #2
JaideepBajwa
lgtm
4 years, 1 month ago (2016-11-04 00:39:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470043006/1
4 years, 1 month ago (2016-11-04 13:39:00 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-04 13:39:02 UTC) #7
john.yan
lgtm
4 years, 1 month ago (2016-11-04 13:50:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470043006/1
4 years, 1 month ago (2016-11-04 14:59:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 15:30:47 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:23:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbab241ca1dc635b78293402b5877ce48784365c
Cr-Commit-Position: refs/heads/master@{#40774}

Powered by Google App Engine
This is Rietveld 408576698