Fix vector resize logic when encoding non-BMP chars to latin1 as ?s

Fix vector resize logic when encoding non-BMP chars to latin1 as ?s

Since non-BMP characters take two UChars, when encoding to latin1 with
replacement characters ('?') may result the output being shorter than
the input. The encoding logic assumed the replacement would always be
larger, and vectors don't like being shrunk. Correct the logic and
make it more readable, add tests.

BUG=661367
R=tkent@chromium.org

Committed: https://crrev.com/9d2d2e8409c21feca88979245ce75f9ac4a00f05
Cr-Commit-Position: refs/heads/master@{#429610}

[jsbell, 2016-11-02 20:11:42]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[jsbell, 2016-11-02 20:12:20]

tkent@ - please take a look? (r? cq?)

[commit-bot: I haz the power, 2016-11-02 20:12:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsittler, 2016-11-02 20:29:19]

bsittler@chromium.org changed reviewers:
+ bsittler@chromium.org

[bsittler, 2016-11-02 20:29:19]

lgtm

[jsbell, 2016-11-02 22:27:19]

Whoops - further experimenting found that the DCHECK_EQ(sizeof(CharType),
sizeof(UChar)); fails.

So hold off for now.

[jsbell, 2016-11-02 22:40:29]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[jsbell, 2016-11-02 22:41:18]

On 2016/11/02 22:27:19, jsbell wrote:
> Whoops - further experimenting found that the DCHECK_EQ(sizeof(CharType),
> sizeof(UChar)); fails.
> 
> So hold off for now.

And that's been fixed - DCHECK removed, comment added, test case added.

tkent@, please do review?

[commit-bot: I haz the power, 2016-11-02 22:41:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jsbell, 2016-11-03 00:13:21]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 00:13:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 02:59:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 02:59:26]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-11-03 12:10:55]

lgtm

[jsbell, 2016-11-03 16:10:13]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-11-03 16:10:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
bsittler@chromium.org
Link to the patchset: https://codereview.chromium.org/2470043004/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2016-11-03 16:10:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 16:16:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-03 16:21:00]

Description was changed from

==========
Fix vector resize logic when encoding non-BMP chars to latin1 as ?s

Since non-BMP characters take two UChars, when encoding to latin1 with
replacement characters ('?') may result the output being shorter than
the input. The encoding logic assumed the replacement would always be
larger, and vectors don't like being shrunk. Correct the logic and
make it more readable, add tests.

BUG=661367
R=tkent@chromium.org
==========

to

==========
Fix vector resize logic when encoding non-BMP chars to latin1 as ?s

Since non-BMP characters take two UChars, when encoding to latin1 with
replacement characters ('?') may result the output being shorter than
the input. The encoding logic assumed the replacement would always be
larger, and vectors don't like being shrunk. Correct the logic and
make it more readable, add tests.

BUG=661367
R=tkent@chromium.org

Committed: https://crrev.com/9d2d2e8409c21feca88979245ce75f9ac4a00f05
Cr-Commit-Position: refs/heads/master@{#429610}
==========

[commit-bot: I haz the power, 2016-11-03 16:21:01]

Patchset 4 (id:??) landed as
https://crrev.com/9d2d2e8409c21feca88979245ce75f9ac4a00f05
Cr-Commit-Position: refs/heads/master@{#429610}