Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 247003004: Add tests for generator/debugger interaction (Closed)

Created:
6 years, 8 months ago by wingo
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Add tests for generator/debugger interaction R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20921

Patch Set 1 #

Total comments: 1

Patch Set 2 : New test, in harmony dir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -0 lines) Patch
A test/mjsunit/harmony/generators-debug-scopes.js View 1 1 chunk +323 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wingo
I'm pretty sure these tests exercise the various scope/debug/generator interactions. Probably we need more related ...
6 years, 8 months ago (2014-04-22 14:20:54 UTC) #1
Yang
Even though it would mean a lot of code duplication, it would be nicer to ...
6 years, 8 months ago (2014-04-22 15:02:34 UTC) #2
wingo
Updated patchset, ptal.
6 years, 8 months ago (2014-04-23 15:39:32 UTC) #3
Yang
On 2014/04/23 15:39:32, wingo wrote: > Updated patchset, ptal. lgtm.
6 years, 8 months ago (2014-04-24 06:02:13 UTC) #4
wingo
6 years, 8 months ago (2014-04-24 07:24:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20921 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698