Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2470023003: Fix JSArrayBuffer is shared check for big endian. (Closed)

Created:
4 years, 1 month ago by mcornac
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, JaideepBajwa, john.yan, JoranSiu, michael_dawson
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix JSArrayBuffer is shared check for big endian. Load the correct 32-bit word to determine if the buffer is shared by using kBitFieldOffset instead of kBitFieldSlot. R=ishell@chromium.org,mstarzinger@chromium.org,jkummerow@chromium.org BUG= LOG=N Committed: https://crrev.com/fb7841b314e73e665c3c13a24ca8d96eec553ac3 Cr-Commit-Position: refs/heads/master@{#40730}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/builtins/builtins-sharedarraybuffer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
mcornac
PTAL
4 years, 1 month ago (2016-11-02 20:32:31 UTC) #1
Michael Starzinger
LGTM.
4 years, 1 month ago (2016-11-03 11:45:26 UTC) #2
Igor Sheludko
lgtm
4 years, 1 month ago (2016-11-03 11:53:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470023003/1
4 years, 1 month ago (2016-11-03 14:06:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 14:34:04 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:20:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb7841b314e73e665c3c13a24ca8d96eec553ac3
Cr-Commit-Position: refs/heads/master@{#40730}

Powered by Google App Engine
This is Rietveld 408576698