third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp - Issue 2470023002: [Presentation API] change initial state of PresentationConnection to 'connecting'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Issue 2470023002: [Presentation API] change initial state of PresentationConnection to 'connecting' (Closed)

Patch Set: resolve code review comments from Derek and rebase with master Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

index 3d2fcd2d12e39e475e5d5df9fd449a97fef2f81a..e7d005333b686f332fb64a173e789ece4d5ca05e 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

@@ -151,8 +151,7 @@ PresentationConnection::PresentationConnection(LocalFrame* frame,

: DOMWindowProperty(frame),

m_id(id),

m_url(url),

- // TODO(zhaobin): change initial state to Connecting. (crbug/659423)

- m_state(WebPresentationConnectionState::Connected),

+ m_state(WebPresentationConnectionState::Connecting),

m_binaryType(BinaryTypeBlob) {}

PresentationConnection::~PresentationConnection() {

« no previous file with comments | « content/browser/presentation/presentation_service_impl_unittest.cc ('k') | no next file » | no next file with comments »