Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Unified Diff: content/browser/presentation/presentation_service_impl.h

Issue 2470023002: [Presentation API] change initial state of PresentationConnection to 'connecting' (Closed)
Patch Set: resolve code review comments from Derek and rebase with master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/presentation/presentation_service_impl.h
diff --git a/content/browser/presentation/presentation_service_impl.h b/content/browser/presentation/presentation_service_impl.h
index 10d08499c161db6c75173548b31af16e76abc597..1a1bb7d5348fa8b2fc951c4dd81fccafbd5af8e1 100644
--- a/content/browser/presentation/presentation_service_impl.h
+++ b/content/browser/presentation/presentation_service_impl.h
@@ -92,7 +92,7 @@ class CONTENT_EXPORT PresentationServiceImpl
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
MaxPendingJoinSessionRequests);
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- ListenForConnectionStateChange);
+ ListenForConnectionStateChangeAndChangeState);
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
ListenForConnectionClose);
@@ -222,8 +222,9 @@ class CONTENT_EXPORT PresentationServiceImpl
void OnSendMessageCallback(bool sent);
// Calls to |delegate_| to start listening for state changes for |connection|.
- // State changes will be returned via |OnConnectionStateChanged|.
- void ListenForConnectionStateChange(
+ // State changes will be returned via |OnConnectionStateChanged|. Change
+ // |connection|'s state to 'connected' after listening.
+ void ListenForConnectionStateChangeAndChangeState(
const PresentationSessionInfo& connection);
// Passed to embedder's implementation of PresentationServiceDelegate for
« no previous file with comments | « chrome/test/media_router/resources/common.js ('k') | content/browser/presentation/presentation_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698