Assert enum type equivalence in UMA_HISTOGRAM_ENUMERATION

Assert enum type equivalence in UMA_HISTOGRAM_ENUMERATION

BUG=661401
Committed: https://crrev.com/ecc63b2b4e76669d5aee9c4045c33d1a684f425b
Cr-Commit-Position: refs/heads/master@{#432799}

[Alexei Svitkine (slow), 2016-11-02 15:48:47]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-11-02 15:48:48]

https://codereview.chromium.org/2469993002/diff/1/base/metrics/histogram_macr...
File base/metrics/histogram_macros.h (right):

https://codereview.chromium.org/2469993002/diff/1/base/metrics/histogram_macr...
base/metrics/histogram_macros.h:45: static_assert(                              
                             \
Thanks for working on this!

Just a nit, can you move the assert to
INTERNAL_HISTOGRAM_ENUMERATION_WITH_FLAG()? We'd like all the implementation
details to live there so as not to clutter this file.

[wychen, 2016-11-02 21:45:04]

https://codereview.chromium.org/2469993002/diff/1/base/metrics/histogram_macr...
File base/metrics/histogram_macros.h (right):

https://codereview.chromium.org/2469993002/diff/1/base/metrics/histogram_macr...
base/metrics/histogram_macros.h:45: static_assert(                              
                             \
On 2016/11/02 15:48:47, Alexei Svitkine (slow) wrote:
> Thanks for working on this!
> 
> Just a nit, can you move the assert to
> INTERNAL_HISTOGRAM_ENUMERATION_WITH_FLAG()? We'd like all the implementation
> details to live there so as not to clutter this file.

Done.

[Alexei Svitkine (slow), 2016-11-03 16:47:29]

lg assuming all the current offenders are cleaned up

[wychen, 2016-11-13 08:16:46]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-13 08:16:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-13 09:26:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-13 09:26:18]

Dry run: This issue passed the CQ dry run.

[wychen, 2016-11-16 18:04:07]

wychen@chromium.org changed reviewers:
+ dcheng@chromium.org

[wychen, 2016-11-16 18:04:08]

Added no-compile tests.

dcheng@, could you take a look at the build file? Thanks!

[wychen, 2016-11-17 01:50:17]

The last fix was landed.
https://codereview.chromium.org/2486453002/

This should pass CQ now.

[wychen, 2016-11-17 01:50:25]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 01:52:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 03:55:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 03:55:11]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_compile_dbg on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_cronet on master.tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)

[Alexei Svitkine (slow), 2016-11-17 04:32:35]

lgtm

[dcheng, 2016-11-17 05:09:55]

lgtm

https://codereview.chromium.org/2469993002/diff/140001/base/metrics/histogram...
File base/metrics/histogram_macros_internal.h (right):

https://codereview.chromium.org/2469993002/diff/140001/base/metrics/histogram...
base/metrics/histogram_macros_internal.h:112: name, 1, boundary, boundary + 1,
flag));        \
I know the ship has sailed (and we're migrating off legacy IPC) but I really
wish legacy IPC and histograms had agreed on how to define the max value.

[wychen, 2016-11-17 06:28:42]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2016-11-17 06:29:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 07:23:41]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-11-17 07:26:37]

Description was changed from

==========
Assert enum type equivalence in UMA_HISTOGRAM_ENUMERATION

BUG=661401
==========

to

==========
Assert enum type equivalence in UMA_HISTOGRAM_ENUMERATION

BUG=661401

Committed: https://crrev.com/ecc63b2b4e76669d5aee9c4045c33d1a684f425b
Cr-Commit-Position: refs/heads/master@{#432799}
==========

[commit-bot: I haz the power, 2016-11-17 07:26:38]

Patchset 8 (id:??) landed as
https://crrev.com/ecc63b2b4e76669d5aee9c4045c33d1a684f425b
Cr-Commit-Position: refs/heads/master@{#432799}