Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2469983007: Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION (Closed)
Patch Set: fix dom test case Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index c7bd628c362ceab76b710601987503f7c45c8cc6..6e4825e01e618972b190c7575157951b3db3125a 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -1314,9 +1314,7 @@ static inline String canonicalizedTitle(Document* document,
bool pendingWhitespace = false;
for (unsigned i = 0; i < length; ++i) {
UChar32 c = characters[i];
- if (c <= 0x20 || c == 0x7F ||
- (WTF::Unicode::category(c) &
- (WTF::Unicode::Separator_Line | WTF::Unicode::Separator_Paragraph))) {
+ if ((c <= 0x20 && c != 0x0b) || c == 0x7F) {
skobes 2016/11/03 14:31:41 Can you use named constants for these instead of m
if (builderIndex != 0)
pendingWhitespace = true;
} else {
« no previous file with comments | « third_party/WebKit/LayoutTests/imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698