Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2469983004:
Remove override of --mmacosx-version-min when building iossim. (Closed)
|
Created:
4 years, 1 month ago by sdefresne Modified:
4 years, 1 month ago Reviewers:
rohitrao (ping after 24h) CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove override of --mmacosx-version-min when building iossim.
Chrome deployment target is now 10.9 so remove override from
iossim when building iOS.
BUG=595295
Committed: https://crrev.com/20a1e2142373f6ef4ba88f1b5d95aa3be572069f
Cr-Commit-Position: refs/heads/master@{#430260}
Patch Set 1 #Patch Set 2 : Fix compilation on iOS. #Patch Set 3 : Remove include_dirs #Messages
Total messages: 21 (15 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sdefresne@chromium.org changed reviewers: + rohitrao@chromium.org
Please take a look and send to CQ if LGTY.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Ping.
lgtm
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Remove override of --mmacosx-version-min when building iossim. Chrome deployment target is now 10.9 so remove override from iossim when building iOS. BUG=595295 ========== to ========== Remove override of --mmacosx-version-min when building iossim. Chrome deployment target is now 10.9 so remove override from iossim when building iOS. BUG=595295 Committed: https://crrev.com/20a1e2142373f6ef4ba88f1b5d95aa3be572069f Cr-Commit-Position: refs/heads/master@{#430260} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/20a1e2142373f6ef4ba88f1b5d95aa3be572069f Cr-Commit-Position: refs/heads/master@{#430260} |
