Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2469943002: DevTools: bring hosted mode up-to-date with the new --custom-devtools-frontend (Closed)

Created:
4 years, 1 month ago by lushnikov
Modified:
4 years, 1 month ago
Reviewers:
chenwilliam
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: bring hosted mode up-to-date with the new --custom-devtools-frontend This patch updates documentation and "npm start" command to use --custom-devtools-frontend flag. BUG=629914 R=chenwilliam@chromium.org Committed: https://crrev.com/bbfd86bce11309c364a92b62d32510006b64a6d8 Cr-Commit-Position: refs/heads/master@{#429200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/readme.md View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/scripts/hosted_mode/server.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
lushnikov
please, take a look
4 years, 1 month ago (2016-11-01 21:58:50 UTC) #1
chenwilliam
lgtm
4 years, 1 month ago (2016-11-02 00:17:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469943002/1
4 years, 1 month ago (2016-11-02 03:40:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 03:58:52 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 04:02:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbfd86bce11309c364a92b62d32510006b64a6d8
Cr-Commit-Position: refs/heads/master@{#429200}

Powered by Google App Engine
This is Rietveld 408576698