Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: components/offline_pages/offline_page_model.h

Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded. (Closed)
Patch Set: Test fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model.h
diff --git a/components/offline_pages/offline_page_model.h b/components/offline_pages/offline_page_model.h
index eb058128a8374c0c27e110a244394c904aa7b6c2..9197db740a71992352a353481c86ad578cd503e8 100644
--- a/components/offline_pages/offline_page_model.h
+++ b/components/offline_pages/offline_page_model.h
@@ -54,9 +54,9 @@ class OfflinePageModel : public base::SupportsUserData {
// Invoked when the model has finished loading.
virtual void OfflinePageModelLoaded(OfflinePageModel* model) = 0;
- // Invoked when the model is being updated, due to adding, removing or
- // updating an offline page.
- virtual void OfflinePageModelChanged(OfflinePageModel* model) = 0;
+ // Invoked when the model is being updated due to adding an offline page.
+ virtual void OfflinePageAdded(OfflinePageModel* model,
Dmitry Titov 2016/11/15 20:02:30 Might be not this patch, but please consider remov
dewittj 2016/11/15 23:54:19 Ack, will do later.
+ const OfflinePageItem& added_page) = 0;
// Invoked when an offline copy related to |offline_id| was deleted.
virtual void OfflinePageDeleted(int64_t offline_id,

Powered by Google App Engine
This is Rietveld 408576698