Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Side by Side Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded. (Closed)
Patch Set: nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h" 5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h"
6 6
7 #include "base/android/callback_android.h" 7 #include "base/android/callback_android.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_array.h" 9 #include "base/android/jni_array.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 env, java_ref_); 225 env, java_ref_);
226 } 226 }
227 227
228 // Implement OfflinePageModel::Observer 228 // Implement OfflinePageModel::Observer
229 void OfflinePageEvaluationBridge::OfflinePageModelLoaded( 229 void OfflinePageEvaluationBridge::OfflinePageModelLoaded(
230 OfflinePageModel* model) { 230 OfflinePageModel* model) {
231 DCHECK_EQ(offline_page_model_, model); 231 DCHECK_EQ(offline_page_model_, model);
232 NotifyIfDoneLoading(); 232 NotifyIfDoneLoading();
233 } 233 }
234 234
235 void OfflinePageEvaluationBridge::OfflinePageModelChanged( 235 void OfflinePageEvaluationBridge::OfflinePageAdded(
236 OfflinePageModel* model) {} 236 OfflinePageModel* model,
237 const OfflinePageItem& added_page) {}
237 238
238 void OfflinePageEvaluationBridge::OfflinePageDeleted( 239 void OfflinePageEvaluationBridge::OfflinePageDeleted(
239 int64_t offline_id, 240 int64_t offline_id,
240 const ClientId& client_id) {} 241 const ClientId& client_id) {}
241 242
242 // Implement RequestCoordinator::Observer 243 // Implement RequestCoordinator::Observer
243 void OfflinePageEvaluationBridge::OnAdded(const SavePageRequest& request) { 244 void OfflinePageEvaluationBridge::OnAdded(const SavePageRequest& request) {
244 JNIEnv* env = base::android::AttachCurrentThread(); 245 JNIEnv* env = base::android::AttachCurrentThread();
245 Java_OfflinePageEvaluationBridge_savePageRequestAdded( 246 Java_OfflinePageEvaluationBridge_savePageRequestAdded(
246 env, java_ref_, ToJavaSavePageRequest(env, request)); 247 env, java_ref_, ToJavaSavePageRequest(env, request));
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 339
339 void OfflinePageEvaluationBridge::NotifyIfDoneLoading() const { 340 void OfflinePageEvaluationBridge::NotifyIfDoneLoading() const {
340 if (!offline_page_model_->is_loaded()) 341 if (!offline_page_model_->is_loaded())
341 return; 342 return;
342 JNIEnv* env = base::android::AttachCurrentThread(); 343 JNIEnv* env = base::android::AttachCurrentThread();
343 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, java_ref_); 344 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, java_ref_);
344 } 345 }
345 346
346 } // namespace android 347 } // namespace android
347 } // namespace offline_pages 348 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698