Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: components/offline_pages/offline_page_model_impl_unittest.cc

Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded. (Closed)
Patch Set: Rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/offline_page_model_impl.h" 5 #include "components/offline_pages/offline_page_model_impl.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <algorithm> 8 #include <algorithm>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 public base::SupportsWeakPtr<OfflinePageModelImplTest> { 70 public base::SupportsWeakPtr<OfflinePageModelImplTest> {
71 public: 71 public:
72 OfflinePageModelImplTest(); 72 OfflinePageModelImplTest();
73 ~OfflinePageModelImplTest() override; 73 ~OfflinePageModelImplTest() override;
74 74
75 void SetUp() override; 75 void SetUp() override;
76 void TearDown() override; 76 void TearDown() override;
77 77
78 // OfflinePageModel::Observer implementation. 78 // OfflinePageModel::Observer implementation.
79 void OfflinePageModelLoaded(OfflinePageModel* model) override; 79 void OfflinePageModelLoaded(OfflinePageModel* model) override;
80 void OfflinePageModelChanged(OfflinePageModel* model) override; 80 void OfflinePageAdded(OfflinePageModel* model,
81 const OfflinePageItem& added_page) override;
81 void OfflinePageDeleted(int64_t offline_id, 82 void OfflinePageDeleted(int64_t offline_id,
82 const ClientId& client_id) override; 83 const ClientId& client_id) override;
83 84
84 // OfflinePageTestArchiver::Observer implementation. 85 // OfflinePageTestArchiver::Observer implementation.
85 void SetLastPathCreatedByArchiver(const base::FilePath& file_path) override; 86 void SetLastPathCreatedByArchiver(const base::FilePath& file_path) override;
86 87
87 // OfflinePageModel callbacks. 88 // OfflinePageModel callbacks.
88 void OnSavePageDone(SavePageResult result, int64_t offline_id); 89 void OnSavePageDone(SavePageResult result, int64_t offline_id);
89 void OnDeletePageDone(DeletePageResult result); 90 void OnDeletePageDone(DeletePageResult result);
90 void OnCheckPagesExistOfflineDone(const CheckPagesExistOfflineResult& result); 91 void OnCheckPagesExistOfflineDone(const CheckPagesExistOfflineResult& result);
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 void OfflinePageModelImplTest::TearDown() { 226 void OfflinePageModelImplTest::TearDown() {
226 model_->RemoveObserver(this); 227 model_->RemoveObserver(this);
227 model_.reset(); 228 model_.reset();
228 PumpLoop(); 229 PumpLoop();
229 } 230 }
230 231
231 void OfflinePageModelImplTest::OfflinePageModelLoaded(OfflinePageModel* model) { 232 void OfflinePageModelImplTest::OfflinePageModelLoaded(OfflinePageModel* model) {
232 ASSERT_EQ(model_.get(), model); 233 ASSERT_EQ(model_.get(), model);
233 } 234 }
234 235
235 void OfflinePageModelImplTest::OfflinePageModelChanged(
236 OfflinePageModel* model) {
237 ASSERT_EQ(model_.get(), model);
238 }
239
240 void OfflinePageModelImplTest::OfflinePageDeleted(int64_t offline_id, 236 void OfflinePageModelImplTest::OfflinePageDeleted(int64_t offline_id,
241 const ClientId& client_id) { 237 const ClientId& client_id) {
242 last_deleted_offline_id_ = offline_id; 238 last_deleted_offline_id_ = offline_id;
243 last_deleted_client_id_ = client_id; 239 last_deleted_client_id_ = client_id;
244 } 240 }
245 241
242 void OfflinePageModelImplTest::OfflinePageAdded(
243 OfflinePageModel* model,
244 const OfflinePageItem& added_page) {
245 ASSERT_EQ(model_.get(), model);
246 }
247
246 void OfflinePageModelImplTest::SetLastPathCreatedByArchiver( 248 void OfflinePageModelImplTest::SetLastPathCreatedByArchiver(
247 const base::FilePath& file_path) { 249 const base::FilePath& file_path) {
248 last_archiver_path_ = file_path; 250 last_archiver_path_ = file_path;
249 } 251 }
250 252
251 void OfflinePageModelImplTest::OnSavePageDone(SavePageResult result, 253 void OfflinePageModelImplTest::OnSavePageDone(SavePageResult result,
252 int64_t offline_id) { 254 int64_t offline_id) {
253 last_save_result_ = result; 255 last_save_result_ = result;
254 last_save_offline_id_ = offline_id; 256 last_save_offline_id_ = offline_id;
255 } 257 }
(...skipping 1051 matching lines...) Expand 10 before | Expand all | Expand 10 after
1307 EXPECT_FALSE(offline_pages::IsOfflinePagesSvelteConcurrentLoadingEnabled()); 1309 EXPECT_FALSE(offline_pages::IsOfflinePagesSvelteConcurrentLoadingEnabled());
1308 1310
1309 // Check if feature is correctly enabled by command-line flag. 1311 // Check if feature is correctly enabled by command-line flag.
1310 base::test::ScopedFeatureList scoped_feature_list; 1312 base::test::ScopedFeatureList scoped_feature_list;
1311 scoped_feature_list.InitAndEnableFeature( 1313 scoped_feature_list.InitAndEnableFeature(
1312 kOfflinePagesSvelteConcurrentLoadingFeature); 1314 kOfflinePagesSvelteConcurrentLoadingFeature);
1313 EXPECT_TRUE(offline_pages::IsOfflinePagesSvelteConcurrentLoadingEnabled()); 1315 EXPECT_TRUE(offline_pages::IsOfflinePagesSvelteConcurrentLoadingEnabled());
1314 } 1316 }
1315 1317
1316 } // namespace offline_pages 1318 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698