Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded. (Closed)
Patch Set: Rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h" 5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h"
6 6
7 #include "base/android/callback_android.h" 7 #include "base/android/callback_android.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_array.h" 9 #include "base/android/jni_array.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 env, java_ref_); 222 env, java_ref_);
223 } 223 }
224 224
225 // Implement OfflinePageModel::Observer 225 // Implement OfflinePageModel::Observer
226 void OfflinePageEvaluationBridge::OfflinePageModelLoaded( 226 void OfflinePageEvaluationBridge::OfflinePageModelLoaded(
227 OfflinePageModel* model) { 227 OfflinePageModel* model) {
228 DCHECK_EQ(offline_page_model_, model); 228 DCHECK_EQ(offline_page_model_, model);
229 NotifyIfDoneLoading(); 229 NotifyIfDoneLoading();
230 } 230 }
231 231
232 void OfflinePageEvaluationBridge::OfflinePageModelChanged( 232 void OfflinePageEvaluationBridge::OfflinePageAdded(
233 OfflinePageModel* model) {} 233 OfflinePageModel* model,
234 const OfflinePageItem& added_page) {}
234 235
235 void OfflinePageEvaluationBridge::OfflinePageDeleted( 236 void OfflinePageEvaluationBridge::OfflinePageDeleted(
236 int64_t offline_id, 237 int64_t offline_id,
237 const ClientId& client_id) {} 238 const ClientId& client_id) {}
238 239
239 // Implement RequestCoordinator::Observer 240 // Implement RequestCoordinator::Observer
240 void OfflinePageEvaluationBridge::OnAdded(const SavePageRequest& request) { 241 void OfflinePageEvaluationBridge::OnAdded(const SavePageRequest& request) {
241 JNIEnv* env = base::android::AttachCurrentThread(); 242 JNIEnv* env = base::android::AttachCurrentThread();
242 Java_OfflinePageEvaluationBridge_savePageRequestAdded( 243 Java_OfflinePageEvaluationBridge_savePageRequestAdded(
243 env, java_ref_, ToJavaSavePageRequest(env, request)); 244 env, java_ref_, ToJavaSavePageRequest(env, request));
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 329
329 void OfflinePageEvaluationBridge::NotifyIfDoneLoading() const { 330 void OfflinePageEvaluationBridge::NotifyIfDoneLoading() const {
330 if (!offline_page_model_->is_loaded()) 331 if (!offline_page_model_->is_loaded())
331 return; 332 return;
332 JNIEnv* env = base::android::AttachCurrentThread(); 333 JNIEnv* env = base::android::AttachCurrentThread();
333 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, java_ref_); 334 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, java_ref_);
334 } 335 }
335 336
336 } // namespace android 337 } // namespace android
337 } // namespace offline_pages 338 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698