Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: components/offline_pages/offline_page_model_impl_unittest.cc

Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded. (Closed)
Patch Set: Test fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/offline_page_model_impl.h" 5 #include "components/offline_pages/offline_page_model_impl.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <algorithm> 8 #include <algorithm>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 public base::SupportsWeakPtr<OfflinePageModelImplTest> { 70 public base::SupportsWeakPtr<OfflinePageModelImplTest> {
71 public: 71 public:
72 OfflinePageModelImplTest(); 72 OfflinePageModelImplTest();
73 ~OfflinePageModelImplTest() override; 73 ~OfflinePageModelImplTest() override;
74 74
75 void SetUp() override; 75 void SetUp() override;
76 void TearDown() override; 76 void TearDown() override;
77 77
78 // OfflinePageModel::Observer implementation. 78 // OfflinePageModel::Observer implementation.
79 void OfflinePageModelLoaded(OfflinePageModel* model) override; 79 void OfflinePageModelLoaded(OfflinePageModel* model) override;
80 void OfflinePageModelChanged(OfflinePageModel* model) override; 80 void OfflinePageAdded(OfflinePageModel* model,
81 const OfflinePageItem& added_page) override;
81 void OfflinePageDeleted(int64_t offline_id, 82 void OfflinePageDeleted(int64_t offline_id,
82 const ClientId& client_id) override; 83 const ClientId& client_id) override;
83 84
84 // OfflinePageTestArchiver::Observer implementation. 85 // OfflinePageTestArchiver::Observer implementation.
85 void SetLastPathCreatedByArchiver(const base::FilePath& file_path) override; 86 void SetLastPathCreatedByArchiver(const base::FilePath& file_path) override;
86 87
87 // OfflinePageModel callbacks. 88 // OfflinePageModel callbacks.
88 void OnSavePageDone(SavePageResult result, int64_t offline_id); 89 void OnSavePageDone(SavePageResult result, int64_t offline_id);
89 void OnDeletePageDone(DeletePageResult result); 90 void OnDeletePageDone(DeletePageResult result);
90 void OnCheckPagesExistOfflineDone(const CheckPagesExistOfflineResult& result); 91 void OnCheckPagesExistOfflineDone(const CheckPagesExistOfflineResult& result);
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 void OfflinePageModelImplTest::TearDown() { 214 void OfflinePageModelImplTest::TearDown() {
214 model_->RemoveObserver(this); 215 model_->RemoveObserver(this);
215 model_.reset(); 216 model_.reset();
216 PumpLoop(); 217 PumpLoop();
217 } 218 }
218 219
219 void OfflinePageModelImplTest::OfflinePageModelLoaded(OfflinePageModel* model) { 220 void OfflinePageModelImplTest::OfflinePageModelLoaded(OfflinePageModel* model) {
220 ASSERT_EQ(model_.get(), model); 221 ASSERT_EQ(model_.get(), model);
221 } 222 }
222 223
223 void OfflinePageModelImplTest::OfflinePageModelChanged(
224 OfflinePageModel* model) {
225 ASSERT_EQ(model_.get(), model);
226 }
227
228 void OfflinePageModelImplTest::OfflinePageDeleted(int64_t offline_id, 224 void OfflinePageModelImplTest::OfflinePageDeleted(int64_t offline_id,
229 const ClientId& client_id) { 225 const ClientId& client_id) {
230 last_deleted_offline_id_ = offline_id; 226 last_deleted_offline_id_ = offline_id;
231 last_deleted_client_id_ = client_id; 227 last_deleted_client_id_ = client_id;
232 } 228 }
233 229
230 void OfflinePageModelImplTest::OfflinePageAdded(
231 OfflinePageModel* model,
232 const OfflinePageItem& added_page) {
233 ASSERT_EQ(model_.get(), model);
234 }
235
234 void OfflinePageModelImplTest::SetLastPathCreatedByArchiver( 236 void OfflinePageModelImplTest::SetLastPathCreatedByArchiver(
235 const base::FilePath& file_path) { 237 const base::FilePath& file_path) {
236 last_archiver_path_ = file_path; 238 last_archiver_path_ = file_path;
237 } 239 }
238 240
239 void OfflinePageModelImplTest::OnSavePageDone(SavePageResult result, 241 void OfflinePageModelImplTest::OnSavePageDone(SavePageResult result,
240 int64_t offline_id) { 242 int64_t offline_id) {
241 last_save_result_ = result; 243 last_save_result_ = result;
242 last_save_offline_id_ = offline_id; 244 last_save_offline_id_ = offline_id;
243 } 245 }
(...skipping 993 matching lines...) Expand 10 before | Expand all | Expand 10 after
1237 EXPECT_FALSE(offline_pages::IsOfflinePagesSvelteConcurrentLoadingEnabled()); 1239 EXPECT_FALSE(offline_pages::IsOfflinePagesSvelteConcurrentLoadingEnabled());
1238 1240
1239 // Check if feature is correctly enabled by command-line flag. 1241 // Check if feature is correctly enabled by command-line flag.
1240 base::test::ScopedFeatureList scoped_feature_list; 1242 base::test::ScopedFeatureList scoped_feature_list;
1241 scoped_feature_list.InitAndEnableFeature( 1243 scoped_feature_list.InitAndEnableFeature(
1242 kOfflinePagesSvelteConcurrentLoadingFeature); 1244 kOfflinePagesSvelteConcurrentLoadingFeature);
1243 EXPECT_TRUE(offline_pages::IsOfflinePagesSvelteConcurrentLoadingEnabled()); 1245 EXPECT_TRUE(offline_pages::IsOfflinePagesSvelteConcurrentLoadingEnabled());
1244 } 1246 }
1245 1247
1246 } // namespace offline_pages 1248 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698