Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded.

components/offline_pages/downloads/download_ui_adapter.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/downloads/download_ui_adapter.h"
 
 #include "base/bind.h"
 #include "base/guid.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
@@ skipping 62 matching lines @@
   --observers_count_;
   // Once the last observer is gone, clear cached data.
   if (observers_count_ == 0)
     ClearCache();
 }
 
 void DownloadUIAdapter::OfflinePageModelLoaded(OfflinePageModel* model) {
   // This signal is not used here.
 }
 
-void DownloadUIAdapter::OfflinePageModelChanged(OfflinePageModel* model) {
+void DownloadUIAdapter::OfflinePageAdded(OfflinePageModel* model,
+                                         const OfflinePageItem& added_page) {
   DCHECK(model == model_);
   model_->GetAllPages(

[Dmitry Titov, 2016/11/15 20:02:30]

Now the impl of this should change to do a direct add instead of re-get all.
Also the OnOfflinePagesChanged should change (likely by being removed?)

[dewittj, 2016/11/15 23:54:19]

I had that in here before (see patchset #2), but in the interest of compact,
focused patches I decided to put it in an upcoming CL.

       base::Bind(&DownloadUIAdapter::OnOfflinePagesChanged,
                  weak_ptr_factory_.GetWeakPtr()));
 }
 
 void DownloadUIAdapter::OfflinePageDeleted(
   int64_t offline_id, const ClientId& client_id) {
   if (!IsVisibleInUI(client_id))
     return;
   std::string guid = client_id.id;
   DownloadUIItems::const_iterator it = items_.find(guid);
@@ skipping 115 matching lines @@
   // TODO(dimich): Consider adding UMA to record user actions.
 }
 
 bool DownloadUIAdapter::IsVisibleInUI(const ClientId& client_id) {
   const std::string& name_space = client_id.name_space;
   return model_->GetPolicyController()->IsSupportedByDownload(name_space) &&
          base::IsValidGUID(client_id.id);
 }
 
 }  // namespace offline_pages