Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded. (Closed)
Patch Set: Test fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h" 5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h"
6 6
7 #include "base/android/callback_android.h" 7 #include "base/android/callback_android.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_array.h" 9 #include "base/android/jni_array.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 env, java_ref_); 233 env, java_ref_);
234 } 234 }
235 235
236 // Implement OfflinePageModel::Observer 236 // Implement OfflinePageModel::Observer
237 void OfflinePageEvaluationBridge::OfflinePageModelLoaded( 237 void OfflinePageEvaluationBridge::OfflinePageModelLoaded(
238 OfflinePageModel* model) { 238 OfflinePageModel* model) {
239 DCHECK_EQ(offline_page_model_, model); 239 DCHECK_EQ(offline_page_model_, model);
240 NotifyIfDoneLoading(); 240 NotifyIfDoneLoading();
241 } 241 }
242 242
243 void OfflinePageEvaluationBridge::OfflinePageModelChanged( 243 void OfflinePageEvaluationBridge::OfflinePageAdded(
244 OfflinePageModel* model) {} 244 OfflinePageModel* model,
245 const OfflinePageItem& added_page) {}
245 246
246 void OfflinePageEvaluationBridge::OfflinePageDeleted( 247 void OfflinePageEvaluationBridge::OfflinePageDeleted(
247 int64_t offline_id, 248 int64_t offline_id,
248 const ClientId& client_id) {} 249 const ClientId& client_id) {}
249 250
250 // Implement RequestCoordinator::Observer 251 // Implement RequestCoordinator::Observer
251 void OfflinePageEvaluationBridge::OnAdded(const SavePageRequest& request) { 252 void OfflinePageEvaluationBridge::OnAdded(const SavePageRequest& request) {
252 JNIEnv* env = base::android::AttachCurrentThread(); 253 JNIEnv* env = base::android::AttachCurrentThread();
253 Java_OfflinePageEvaluationBridge_savePageRequestAdded( 254 Java_OfflinePageEvaluationBridge_savePageRequestAdded(
254 env, java_ref_, ToJavaSavePageRequest(env, request)); 255 env, java_ref_, ToJavaSavePageRequest(env, request));
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 340
340 void OfflinePageEvaluationBridge::NotifyIfDoneLoading() const { 341 void OfflinePageEvaluationBridge::NotifyIfDoneLoading() const {
341 if (!offline_page_model_->is_loaded()) 342 if (!offline_page_model_->is_loaded())
342 return; 343 return;
343 JNIEnv* env = base::android::AttachCurrentThread(); 344 JNIEnv* env = base::android::AttachCurrentThread();
344 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, java_ref_); 345 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, java_ref_);
345 } 346 }
346 347
347 } // namespace android 348 } // namespace android
348 } // namespace offline_pages 349 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698