Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(207)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/paint/tables/composited-table-background.html
Issue
2469903002
:
Use appropriate background object visual rect for composited table cell backgrounds. (Closed)
Patch Set: Include row background client when invalidating.
Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/paint/tables/composited-table-background.html
third_party/WebKit/LayoutTests/paint/tables/composited-table-background-expected.png
third_party/WebKit/LayoutTests/paint/tables/composited-table-background-expected.txt
third_party/WebKit/Source/core/layout/LayoutTableCell.h
third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
third_party/WebKit/Source/core/paint/TableCellPainter.h
third_party/WebKit/Source/core/paint/TableCellPainter.cpp
third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/paint/tables/composited-table-background-expected.png »
('j') |
third_party/WebKit/Source/core/layout/LayoutTableCell.cpp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!doctype html>
2
<script src="../../resources/run-after-layout-and-paint.js"></script>
3
<style>
4
td {
5
padding: 0 24px;
6
height: 64px;
7
}
8
</style>
9
Test passes if all of the cells in the second row of the table have a blue backg round.
10
<table>
11
<tr>
12
<td>A</td>
13
<td>B</td>
14
<td>C</td>
15
</tr>
16
<tr id="target">
17
<td>D</td>
18
<td style="will-change: transform;">E</td>
19
<td>F</td>
20
</tr>
21
</table>
22
<script>
23
runAfterLayoutAndPaint(function() {
24
target.style.backgroundColor = 'lightBlue';
25
}, true);
26
</script>
OLD
NEW
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/paint/tables/composited-table-background-expected.png »
('j') |
third_party/WebKit/Source/core/layout/LayoutTableCell.cpp »
('J')
Issue 2469903002: Use appropriate background object visual rect for composited table cell backgrounds. (Closed)
Created 4 years, 1 month ago by wkorman
Modified 3 years, 10 months ago
Reviewers: Xianzhu, chrishtr
Base URL:
Comments: 16
This is Rietveld
408576698