xfa/fwl/core/ifwl_checkbox.cpp - Issue 2469893004: Unify CFWL_WidgetProperties and CFWL_WidgetImpProperties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/core/ifwl_checkbox.cpp

Issue 2469893004: Unify CFWL_WidgetProperties and CFWL_WidgetImpProperties. (Closed)

Patch Set: review cleanup Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/core/ifwl_checkbox.cpp

diff --git a/xfa/fwl/core/ifwl_checkbox.cpp b/xfa/fwl/core/ifwl_checkbox.cpp

index f03b86471728e474105ab7af9d099e8370ba2766..a8f4936b29ad45065a028db986fbf486c6e730b1 100644

--- a/xfa/fwl/core/ifwl_checkbox.cpp

+++ b/xfa/fwl/core/ifwl_checkbox.cpp

@@ -26,8 +26,8 @@ const int kCaptionMargin = 5;

} // namespace

IFWL_CheckBox::IFWL_CheckBox(const IFWL_App* app,

- const CFWL_WidgetImpProperties& properties)

- : IFWL_Widget(app, properties, nullptr),

+ std::unique_ptr<CFWL_WidgetProperties> properties)

+ : IFWL_Widget(app, std::move(properties), nullptr),

m_dwTTOStyles(FDE_TTOSTYLE_SingleLine),

m_iTTOAlign(FDE_TTOALIGNMENT_Center),

m_bBtnDown(false) {

« no previous file with comments | « xfa/fwl/core/ifwl_checkbox.h ('k') | xfa/fwl/core/ifwl_combobox.h » ('j') | no next file with comments »