Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4156)

Unified Diff: cc/output/gl_renderer.cc

Issue 2469893003: [Merge to 2883] mac: Fix bug where opacity is applied twice on RenderPassDrawQuads. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/test/data/gpu/filter_effects.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/gl_renderer.cc
diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc
index 7ed3ab9f7af91476d6d79e6e47980c0d5cd66110..148a9649873b5ccb895433e37dfbfdd98f9d2e6c 100644
--- a/cc/output/gl_renderer.cc
+++ b/cc/output/gl_renderer.cc
@@ -4039,9 +4039,10 @@ void GLRenderer::ScheduleRenderPassDrawQuad(
transform.asColMajorf(gl_transform);
unsigned filter = ca_layer_overlay->filter;
- gl_->ScheduleCALayerSharedStateCHROMIUM(
- ca_layer_overlay->shared_state->opacity, is_clipped, clip_rect,
- sorting_context_id, gl_transform);
+ // The alpha has already been applied when copying the RPDQ to an IOSurface.
+ GLfloat alpha = 1;
+ gl_->ScheduleCALayerSharedStateCHROMIUM(alpha, is_clipped, clip_rect,
+ sorting_context_id, gl_transform);
gl_->ScheduleCALayerCHROMIUM(
texture_id, contents_rect, ca_layer_overlay->background_color,
ca_layer_overlay->edge_aa_mask, bounds_rect, filter);
« no previous file with comments | « no previous file | content/test/data/gpu/filter_effects.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698