Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: ash/common/devtools/ash_devtools_dom_agent.h

Issue 2469883002: Add test for ash devtools DOM agent getDocument method (Closed)
Patch Set: Remove unnecessary code Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/devtools/ash_devtools_dom_agent.h
diff --git a/ash/common/devtools/ash_devtools_dom_agent.h b/ash/common/devtools/ash_devtools_dom_agent.h
index 3bb0dd016db9de0d34290c7d63c486693850f842..85286538db936290ac1daa2938335855f9eacbdb 100644
--- a/ash/common/devtools/ash_devtools_dom_agent.h
+++ b/ash/common/devtools/ash_devtools_dom_agent.h
@@ -6,21 +6,20 @@
#define ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_
#include "ash/common/wm_shell.h"
+#include "base/compiler_specific.h"
#include "components/ui_devtools/DOM.h"
#include "components/ui_devtools/devtools_base_agent.h"
namespace ash {
namespace devtools {
-class AshDevToolsDOMAgent : public ui::devtools::UiDevToolsBaseAgent<
- ui::devtools::protocol::DOM::Metainfo> {
+class ASH_EXPORT AshDevToolsDOMAgent
+ : public NON_EXPORTED_BASE(ui::devtools::UiDevToolsBaseAgent<
+ ui::devtools::protocol::DOM::Metainfo>) {
public:
explicit AshDevToolsDOMAgent(ash::WmShell* shell);
~AshDevToolsDOMAgent() override;
- private:
- std::unique_ptr<ui::devtools::protocol::DOM::Node> BuildInitialTree();
-
// DOM::Backend
void enable(ui::devtools::protocol::ErrorString* error) override {}
void disable(ui::devtools::protocol::ErrorString* error) override {}
@@ -28,6 +27,9 @@ class AshDevToolsDOMAgent : public ui::devtools::UiDevToolsBaseAgent<
ui::devtools::protocol::ErrorString* error,
std::unique_ptr<ui::devtools::protocol::DOM::Node>* out_root) override;
+ private:
+ std::unique_ptr<ui::devtools::protocol::DOM::Node> BuildInitialTree();
+
ash::WmShell* shell_;
DISALLOW_COPY_AND_ASSIGN(AshDevToolsDOMAgent);

Powered by Google App Engine
This is Rietveld 408576698