Add test for ash devtools DOM agent getDocument method

Add test for ash devtools DOM agent getDocument method

Added a test to make sure correct DOM hierarchy is built
and added helper methods to compare windows, widgets and views to DOM nodes.

BUG=648701
Committed: https://crrev.com/61f8685225e0e823b0121b1f2adabcbda9df8387
Cr-Commit-Position: refs/heads/master@{#429580}

[Sarmad Hashmi, 2016-11-01 19:54:26]

mhashmi@chromium.org changed reviewers:
+ sadrul@chromium.org

[Sarmad Hashmi, 2016-11-01 19:58:09]

Description was changed from

==========
Add test for ash devtools DOM agent getDocument method

A couple of changes here:
- Added a test to make sure correct DOM hierarchy is built
and added helper methods to compare windows, widgets and views to DOM nodes.
- Move common methods in the generated Backend classes
to the UiDevToolsBaseAgent.
- Add UI_DEVTOOLS_EXPORT (the tests were throwing linker errors without this)

BUG=648701
==========

to

==========
Add test for ash devtools DOM agent getDocument method

Added a test to make sure correct DOM hierarchy is built
and added helper methods to compare windows, widgets and views to DOM nodes.

BUG=648701
==========

[sadrul, 2016-11-02 15:23:05]

https://codereview.chromium.org/2469883002/diff/20001/ash/common/devtools/ash...
File ash/common/devtools/ash_devtools_unittest.cc (right):

https://codereview.chromium.org/2469883002/diff/20001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:34: if (attributes->get(i) ==
attribute) {
Don't need {}

https://codereview.chromium.org/2469883002/diff/20001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:133:
dom_agent()->getDocument(nullptr, &root);
use some variable for the nullptr error string, e.g.

  const ErrorString* kNullError = nullptr;
  dom_agent()->getDocument(kNullError, &root);

ditto for getChildren() calls below.

https://codereview.chromium.org/2469883002/diff/20001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:139: Compare(child_window,
parent_node->getChildren(nullptr)->get(0));
First ASSERT() that parent_node->getChildren(nullptr)) is non-null (because if
it is null, then it will cause a crash, whereas ASSERT() would fail the test,
and abort the test, i.e. it will not run the code below, thus avoiding the
crash)

[Sarmad Hashmi, 2016-11-02 16:32:24]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[Sarmad Hashmi, 2016-11-02 16:32:34]

https://codereview.chromium.org/2469883002/diff/20001/ash/common/devtools/ash...
File ash/common/devtools/ash_devtools_unittest.cc (right):

https://codereview.chromium.org/2469883002/diff/20001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:34: if (attributes->get(i) ==
attribute) {
On 2016/11/02 15:23:05, sadrul wrote:
> Don't need {}

Done.

https://codereview.chromium.org/2469883002/diff/20001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:133:
dom_agent()->getDocument(nullptr, &root);
On 2016/11/02 15:23:05, sadrul wrote:
> use some variable for the nullptr error string, e.g.
> 
>   const ErrorString* kNullError = nullptr;
>   dom_agent()->getDocument(kNullError, &root);
> 
> ditto for getChildren() calls below.

Done.

https://codereview.chromium.org/2469883002/diff/20001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_unittest.cc:139: Compare(child_window,
parent_node->getChildren(nullptr)->get(0));
On 2016/11/02 15:23:05, sadrul wrote:
> First ASSERT() that parent_node->getChildren(nullptr)) is non-null (because if
> it is null, then it will cause a crash, whereas ASSERT() would fail the test,
> and abort the test, i.e. it will not run the code below, thus avoiding the
> crash)

Done.

[commit-bot: I haz the power, 2016-11-02 16:32:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-11-02 17:00:35]

lgtm

[commit-bot: I haz the power, 2016-11-02 17:56:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 17:56:09]

Dry run: This issue passed the CQ dry run.

[Sarmad Hashmi, 2016-11-03 02:42:57]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 02:43:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 04:15:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 04:15:15]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Sarmad Hashmi, 2016-11-03 04:55:43]

The CQ bit was checked by mhashmi@chromium.org

[Sarmad Hashmi, 2016-11-03 04:55:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2469883002/#ps60001
(title: "use new devtools style")

[commit-bot: I haz the power, 2016-11-03 04:55:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 06:56:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 06:56:41]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Sarmad Hashmi, 2016-11-03 14:38:39]

The CQ bit was checked by mhashmi@chromium.org

[commit-bot: I haz the power, 2016-11-03 14:39:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 14:44:19]

Description was changed from

==========
Add test for ash devtools DOM agent getDocument method

Added a test to make sure correct DOM hierarchy is built
and added helper methods to compare windows, widgets and views to DOM nodes.

BUG=648701
==========

to

==========
Add test for ash devtools DOM agent getDocument method

Added a test to make sure correct DOM hierarchy is built
and added helper methods to compare windows, widgets and views to DOM nodes.

BUG=648701
==========

[commit-bot: I haz the power, 2016-11-03 14:44:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-03 14:47:29]

Description was changed from

==========
Add test for ash devtools DOM agent getDocument method

Added a test to make sure correct DOM hierarchy is built
and added helper methods to compare windows, widgets and views to DOM nodes.

BUG=648701
==========

to

==========
Add test for ash devtools DOM agent getDocument method

Added a test to make sure correct DOM hierarchy is built
and added helper methods to compare windows, widgets and views to DOM nodes.

BUG=648701

Committed: https://crrev.com/61f8685225e0e823b0121b1f2adabcbda9df8387
Cr-Commit-Position: refs/heads/master@{#429580}
==========

[commit-bot: I haz the power, 2016-11-03 14:47:30]

Patchset 4 (id:??) landed as
https://crrev.com/61f8685225e0e823b0121b1f2adabcbda9df8387
Cr-Commit-Position: refs/heads/master@{#429580}