Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: third_party/WebKit/Source/web/WebFrameSerializer.cpp

Issue 2469873002: [ImageResource 4] Split ImageResource into Resource and Image parts (Closed)
Patch Set: comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrameSerializer.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameSerializer.cpp b/third_party/WebKit/Source/web/WebFrameSerializer.cpp
index 2761caac1e1b3e3b8e44f692da8e29c9db19e742..562d0e4f4e255f970aed0b4da0aed9a55c08c471 100644
--- a/third_party/WebKit/Source/web/WebFrameSerializer.cpp
+++ b/third_party/WebKit/Source/web/WebFrameSerializer.cpp
@@ -84,7 +84,7 @@ class MHTMLFrameSerializerDelegate final : public FrameSerializer::Delegate {
bool shouldIgnoreAttribute(const Attribute&) override;
bool rewriteLink(const Element&, String& rewrittenLink) override;
bool shouldSkipResourceWithURL(const KURL&) override;
- bool shouldSkipResource(const Resource&) override;
+ bool shouldSkipResource(bool hasCacheControlNoStoreHeader) override;
private:
WebFrameSerializer::MHTMLPartsGenerationDelegate& m_webDelegate;
@@ -144,11 +144,11 @@ bool MHTMLFrameSerializerDelegate::shouldSkipResourceWithURL(const KURL& url) {
}
bool MHTMLFrameSerializerDelegate::shouldSkipResource(
- const Resource& resource) {
+ bool hasCacheControlNoStoreHeader) {
return m_webDelegate.cacheControlPolicy() ==
WebFrameSerializerCacheControlPolicy::
SkipAnyFrameOrResourceMarkedNoStore &&
- resource.hasCacheControlNoStoreHeader();
+ hasCacheControlNoStoreHeader;
}
bool cacheControlNoStoreHeaderPresent(

Powered by Google App Engine
This is Rietveld 408576698