third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp - Issue 2469873002: [ImageResource 4] Split ImageResource into Resource and Image parts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp

Issue 2469873002: [ImageResource 4] Split ImageResource into Resource and Image parts (Closed)

Patch Set: comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/ImageLoader.cpp ('K') | « third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp ('k') | third_party/WebKit/Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp

diff --git a/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp b/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp

index 20bf8ef46e8abaf1e473c77717ece1648392f6ad..d5e78884a037678b1bf106da57628650a8d26dd9 100644

--- a/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp

+++ b/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp

@@ -112,7 +112,7 @@ void SVGImageChromeClient::animationTimerFired(TimerBase*) {

return;

// The SVGImageChromeClient object's lifetime is dependent on

- // the ImageObserver (an ImageResource) of its image. Should it

+ // the ImageObserver (an ImageResourceContent) of its image. Should it

// be dead and about to be lazily swept out, do not proceed.

// TODO(Oilpan): move (SVG)Image to the Oilpan heap, and avoid