[ImageResource 4] Split ImageResource into Resource and Image parts

third_party/WebKit/Source/core/fetch/ImageResourceInfo.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ImageResourceInfo_h
+#define ImageResourceInfo_h
+
+#include "core/CoreExport.h"
+#include "core/fetch/ResourceStatus.h"
+#include "platform/heap/Heap.h"
+#include "platform/weborigin/KURL.h"

[yhirano, 2016/12/05 09:02:04]

+wtf/Forward.h

[hiroshige, 2016/12/06 09:32:51]

Done.

+
+namespace blink {
+
+class ResourceError;
+class ResourceFetcher;
+class ResourceResponse;
+class SecurityOrigin;
+
+// Delegate class of ImageResource that encapsulates the interface and data
+// visible to ImageResourceContent.
+// TODO(hiroshige): reduce the members of this class to further decouple
+// ImageResource and ImageResourceContent.
+class CORE_EXPORT ImageResourceInfo : public GarbageCollectedMixin {
+ public:
+  ~ImageResourceInfo() {}
+  virtual const KURL& url() const = 0;
+  virtual bool isSchedulingReload() const = 0;
+  virtual bool hasDevicePixelRatioHeaderValue() const = 0;
+  virtual float devicePixelRatioHeaderValue() const = 0;
+  virtual const ResourceResponse& response() const = 0;
+  virtual ResourceStatus getStatus() const = 0;
+  virtual bool isPlaceholder() const = 0;
+  virtual bool isCacheValidator() const = 0;
+  virtual bool schedulingReloadOrShouldReloadBrokenPlaceholder() const = 0;
+  virtual bool isAccessAllowed(

[yhirano, 2016/12/05 09:02:03]

Please use enum rather than boolean for a public method parameter.

[hiroshige, 2016/12/06 09:32:51]

Done.

+      SecurityOrigin*,
+      bool doesCurrentFrameHasSingleSecurityOrigin) const = 0;
+  virtual bool hasCacheControlNoStoreHeader() const = 0;
+  virtual const ResourceError& resourceError() const = 0;
+
+  DEFINE_INLINE_VIRTUAL_TRACE() {}

[yhirano, 2016/12/05 09:02:03]

[optional] can you place this function at the bottom?

[hiroshige, 2016/12/06 09:32:51]

Done.

+
+  virtual void decodeError(bool allDataReceived) {}

[yhirano, 2016/12/05 09:02:03]

It might be good to have comments for non-trivial public methods.

[yhirano, 2016/12/05 09:02:03]

Can you tell me why these functions have the default implementations unlike
above ones?

[hiroshige, 2016/12/06 09:32:51]

The most thing I want to say for these methods is: Don't use, remove them.
So added such comments.

Although they are public, the members inherit the tight dependencies to and bugs
of the internals of ImageResource, and all of the non-const methods need care
when used.

[hiroshige, 2016/12/06 09:32:51]

I made e.g. url() abstract because we need a dummy KURL object if there is no
corresponding Resource (which is in NullImageResourceInfo).
I don't have any reason to have default implementation here, so I made them
abstract in the latest PatchSet.

+  virtual void setDecodedSize(size_t) {}
+  virtual void willAddClientOrObserver() {}
+  virtual void didRemoveClientOrObserver() {}
+  virtual void emulateLoadStartedForInspector(
+      ResourceFetcher*,
+      const KURL&,
+      const AtomicString& initiatorName) {}
+};
+
+}  // namespace blink
+
+#endif