Move all ProvisionFetcher classes out of android/ subdirectories.

Move all ProvisionFetcher classes out of android/ subdirectories.

The Cast Linux build will use this interface to provision devices
from the "media" service. Move these classes into general subdirs and
update BUILD.gn files so that these build on Linux.

The only non-mechanical change in this CL is that
content::CreateProvisionFetcher() now takes a net::URLRequestContextGetter*
instead of a RenderFrameHost*. This will allow more flexibility for content
embedders like Chromecast to use this class.

BUG=660736
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/a0da430a19a674050860c392ca879fc9c82b559f
Cr-Commit-Position: refs/heads/master@{#430308}

[slan, 2016-11-04 18:01:36]

Description was changed from

==========
Move all ProvisionFetcher classes out of android/ subdirectories.

The Cast Linux build will use this interface to provision devices
from the "media" service. Move these classes into general subdirs and
update BUILD.gn files so that these build on Linux.

The only non-mechanical change in this CL is that
content::CreateProvisionFetcher() now takes a net::URLRequestContextGetter*
instead of a RenderFrameHost*. This will allow more flexibility for content
embedders like Chromecast to use this class.

BUG=660736
==========

to

==========
Move all ProvisionFetcher classes out of android/ subdirectories.

The Cast Linux build will use this interface to provision devices
from the "media" service. Move these classes into general subdirs and
update BUILD.gn files so that these build on Linux.

The only non-mechanical change in this CL is that
content::CreateProvisionFetcher() now takes a net::URLRequestContextGetter*
instead of a RenderFrameHost*. This will allow more flexibility for content
embedders like Chromecast to use this class.

BUG=660736
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[slan, 2016-11-04 18:02:01]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 18:02:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 18:30:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 18:30:28]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[slan, 2016-11-04 18:44:40]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 18:45:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[slan, 2016-11-04 18:47:42]

slan@chromium.org changed reviewers:
+ alokp@chromium.org, xhwang@chromium.org

[slan, 2016-11-04 18:47:42]

Xiaohan, this is the subset of ccrev.com/2472203002 that moves the Android files
as needed. Regardless of how we expose this interface to the "media" service
(still in discussion), we will want to use it on Cast. Please take a look! 

I will add other reviewers for rubber stamps later today. 

+Alok for FYI

[commit-bot: I haz the power, 2016-11-04 20:03:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 20:03:13]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[xhwang, 2016-11-05 02:58:42]

LGTM

https://codereview.chromium.org/2469863010/diff/20001/content/browser/media/u...
File content/browser/media/url_provision_fetcher.h (right):

https://codereview.chromium.org/2469863010/diff/20001/content/browser/media/u...
content/browser/media/url_provision_fetcher.h:41: #endif  //
CONTENT_BROWSER_MEDIA_URL_PROVISION_FETCHER_H_
thanks for catching this

[slan, 2016-11-06 05:16:58]

The CQ bit was checked by slan@chromium.org

[slan, 2016-11-06 05:16:59]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2469863010/#ps40001
(title: "Remove EXPORT from pure virtual interface.")

[commit-bot: I haz the power, 2016-11-06 05:17:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-06 05:23:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-06 05:23:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[slan, 2016-11-06 17:19:41]

The CQ bit was checked by slan@chromium.org

[slan, 2016-11-06 17:19:42]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2469863010/#ps60001
(title: "Use NON_EXPORTED_BASE to suppress MSVC C4275")

[commit-bot: I haz the power, 2016-11-06 17:19:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-06 17:28:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-06 17:28:17]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[slan, 2016-11-06 17:43:30]

slan@chromium.org changed reviewers:
+ avi@chromium.org, clamy@chromium.org, dcheng@chromium.org

[slan, 2016-11-06 17:43:31]

+clamy@ for content/browser/, content/public/browser/
+avi@ for the same (since clamy@ is marked slow)
+dcheng@ for comment changes in media/mojo/interfaces

Hey all, PTAL. Thanks!

[Avi (use Gerrit), 2016-11-06 18:02:44]

lgtm

[dcheng, 2016-11-06 19:35:24]

LGTM with nit addressed and a bug filed for the todo

https://codereview.chromium.org/2469863010/diff/60001/media/mojo/interfaces/p...
File media/mojo/interfaces/provision_fetcher.mojom (right):

https://codereview.chromium.org/2469863010/diff/60001/media/mojo/interfaces/p...
media/mojo/interfaces/provision_fetcher.mojom:16: Retrieve(string default_url,
string request_data)
Please add a TODO to use url.mojom.Url here.

[slan, 2016-11-06 22:08:41]

The tryjob failures appear unrelated at first glance.

https://codereview.chromium.org/2469863010/diff/60001/media/mojo/interfaces/p...
File media/mojo/interfaces/provision_fetcher.mojom (right):

https://codereview.chromium.org/2469863010/diff/60001/media/mojo/interfaces/p...
media/mojo/interfaces/provision_fetcher.mojom:16: Retrieve(string default_url,
string request_data)
On 2016/11/06 19:35:24, dcheng wrote:
> Please add a TODO to use url.mojom.Url here.

Done.

[slan, 2016-11-06 22:08:47]

The CQ bit was checked by slan@chromium.org

[slan, 2016-11-06 22:08:47]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
avi@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2469863010/#ps80001
(title: "Add TODO for crbug.com/662752")

[commit-bot: I haz the power, 2016-11-06 22:08:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-06 23:35:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-06 23:35:30]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[slan, 2016-11-07 15:43:20]

The CQ bit was checked by slan@chromium.org

[slan, 2016-11-07 15:43:21]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
avi@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2469863010/#ps100001
(title: "Another NON_EXPORTED_BASE.")

[commit-bot: I haz the power, 2016-11-07 15:43:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 17:37:35]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-07 17:44:09]

Description was changed from

==========
Move all ProvisionFetcher classes out of android/ subdirectories.

The Cast Linux build will use this interface to provision devices
from the "media" service. Move these classes into general subdirs and
update BUILD.gn files so that these build on Linux.

The only non-mechanical change in this CL is that
content::CreateProvisionFetcher() now takes a net::URLRequestContextGetter*
instead of a RenderFrameHost*. This will allow more flexibility for content
embedders like Chromecast to use this class.

BUG=660736
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move all ProvisionFetcher classes out of android/ subdirectories.

The Cast Linux build will use this interface to provision devices
from the "media" service. Move these classes into general subdirs and
update BUILD.gn files so that these build on Linux.

The only non-mechanical change in this CL is that
content::CreateProvisionFetcher() now takes a net::URLRequestContextGetter*
instead of a RenderFrameHost*. This will allow more flexibility for content
embedders like Chromecast to use this class.

BUG=660736
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/a0da430a19a674050860c392ca879fc9c82b559f
Cr-Commit-Position: refs/heads/master@{#430308}
==========

[commit-bot: I haz the power, 2016-11-07 17:44:10]

Patchset 6 (id:??) landed as
https://crrev.com/a0da430a19a674050860c392ca879fc9c82b559f
Cr-Commit-Position: refs/heads/master@{#430308}