Delegate dragend to the correct frame's EventHandler.

Delegate dragend to the correct frame's EventHandler.

Currently, most drag-and-drop events are correctly delegated to the
EventHandler of the frame that contains the events' target elements, in
EventHandler::updateDragAndDrop. However,
EventHandler::dragSourceEndedAt does not implement this delegation.  The
issue is visible to the Web in a subtle way -- the frame of the
EventHandler is used to populate the DragEvent's view, which is used to
compute the clientX and clientY attributes, which are user-visible.

This CL implements the delegation used by
MouseEventManager::dispatchDragSrcEvent, into
MouseEventManager::dispatchDragSrcEvent.

BUG=618770
Committed: https://crrev.com/32e50971f32bcd21be8540758efe9aac0ffafcd9
Cr-Commit-Position: refs/heads/master@{#429669}

[pwnall, 2016-11-02 10:10:06]

Description was changed from

==========
Attempt to repro crbug.com/618770

BUG=618770
==========

to

==========
Tests for crbug.com/618770

BUG=618770
==========

[pwnall, 2016-11-02 17:22:46]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 17:23:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2016-11-02 18:58:24]

Description was changed from

==========
Tests for crbug.com/618770

BUG=618770
==========

to

==========
Delegate dragend to the correct frame's EventHandler.

Currently, most drag-and-drop events are correctly delegated to the
EventHandler of the frame that contains the events' target elements, in
EventHandler::updateDragAndDrop. However,
EventHandler::dragSourceEndedAt does not implement this delegation.  The
issue is visible to the Web in a subtle way -- the frame of the
EventHandler is used to populate the DragEvent's view, which is used to
compute the clientX and clientY attributes, which are user-visible.

This CL implements the delegation used by
MouseEventManager::dispatchDragSrcEvent, into
MouseEventManager::dispatchDragSrcEvent.

BUG=618770
==========

[pwnall, 2016-11-02 18:58:32]

Patchset #1 (id:1) has been deleted

[pwnall, 2016-11-02 18:58:39]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-11-02 19:44:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 19:44:09]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pwnall, 2016-11-02 20:15:46]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 20:16:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2016-11-02 21:15:43]

pwnall@chromium.org changed reviewers:
+ dcheng@chromium.org

[pwnall, 2016-11-02 21:15:44]

PTAL?

[commit-bot: I haz the power, 2016-11-02 21:28:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 21:28:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pwnall, 2016-11-03 00:46:20]

Patchset #3 (id:80001) has been deleted

[pwnall, 2016-11-03 00:46:47]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 00:47:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 02:31:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 02:32:00]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dcheng, 2016-11-03 03:05:34]

Apparently you need to check if targetFrame is non-null after calling
targetIsFrame()? Very odd.

[dcheng, 2016-11-03 03:09:59]

https://codereview.chromium.org/2469863003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/2469863003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/input/EventHandler.cpp:1976:
targetFrame->eventHandler().dragSourceEndedAt(event, operation);
Specifically, null-checking targetFrame here fixes both failing test locally for
me.

[pwnall, 2016-11-03 05:02:40]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 05:02:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 07:03:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 07:03:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[pwnall, 2016-11-03 09:09:14]

On 2016/11/03 03:09:59, dcheng wrote:
>
https://codereview.chromium.org/2469863003/diff/100001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/input/EventHandler.cpp (right):
> 
>
https://codereview.chromium.org/2469863003/diff/100001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/input/EventHandler.cpp:1976:
> targetFrame->eventHandler().dragSourceEndedAt(event, operation);
> Specifically, null-checking targetFrame here fixes both failing test locally
for
> me.

dcheng@: Thank you very much for pointing this out! I'm not sure how I managed
to miss the null-pointer check... it was there on _all_ the other code paths :'(

PTAL?

[dcheng, 2016-11-03 19:05:16]

lgtm

[pwnall, 2016-11-03 19:15:07]

The CQ bit was checked by pwnall@chromium.org

[pwnall, 2016-11-03 19:15:32]

On 2016/11/03 19:05:16, dcheng wrote:
> lgtm

Thank you very much for your guidance!

[commit-bot: I haz the power, 2016-11-03 19:16:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 19:22:58]

Description was changed from

==========
Delegate dragend to the correct frame's EventHandler.

Currently, most drag-and-drop events are correctly delegated to the
EventHandler of the frame that contains the events' target elements, in
EventHandler::updateDragAndDrop. However,
EventHandler::dragSourceEndedAt does not implement this delegation.  The
issue is visible to the Web in a subtle way -- the frame of the
EventHandler is used to populate the DragEvent's view, which is used to
compute the clientX and clientY attributes, which are user-visible.

This CL implements the delegation used by
MouseEventManager::dispatchDragSrcEvent, into
MouseEventManager::dispatchDragSrcEvent.

BUG=618770
==========

to

==========
Delegate dragend to the correct frame's EventHandler.

Currently, most drag-and-drop events are correctly delegated to the
EventHandler of the frame that contains the events' target elements, in
EventHandler::updateDragAndDrop. However,
EventHandler::dragSourceEndedAt does not implement this delegation.  The
issue is visible to the Web in a subtle way -- the frame of the
EventHandler is used to populate the DragEvent's view, which is used to
compute the clientX and clientY attributes, which are user-visible.

This CL implements the delegation used by
MouseEventManager::dispatchDragSrcEvent, into
MouseEventManager::dispatchDragSrcEvent.

BUG=618770
==========

[commit-bot: I haz the power, 2016-11-03 19:22:59]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-11-03 19:46:53]

Description was changed from

==========
Delegate dragend to the correct frame's EventHandler.

Currently, most drag-and-drop events are correctly delegated to the
EventHandler of the frame that contains the events' target elements, in
EventHandler::updateDragAndDrop. However,
EventHandler::dragSourceEndedAt does not implement this delegation.  The
issue is visible to the Web in a subtle way -- the frame of the
EventHandler is used to populate the DragEvent's view, which is used to
compute the clientX and clientY attributes, which are user-visible.

This CL implements the delegation used by
MouseEventManager::dispatchDragSrcEvent, into
MouseEventManager::dispatchDragSrcEvent.

BUG=618770
==========

to

==========
Delegate dragend to the correct frame's EventHandler.

Currently, most drag-and-drop events are correctly delegated to the
EventHandler of the frame that contains the events' target elements, in
EventHandler::updateDragAndDrop. However,
EventHandler::dragSourceEndedAt does not implement this delegation.  The
issue is visible to the Web in a subtle way -- the frame of the
EventHandler is used to populate the DragEvent's view, which is used to
compute the clientX and clientY attributes, which are user-visible.

This CL implements the delegation used by
MouseEventManager::dispatchDragSrcEvent, into
MouseEventManager::dispatchDragSrcEvent.

BUG=618770

Committed: https://crrev.com/32e50971f32bcd21be8540758efe9aac0ffafcd9
Cr-Commit-Position: refs/heads/master@{#429669}
==========

[commit-bot: I haz the power, 2016-11-03 19:46:54]

Patchset 4 (id:??) landed as
https://crrev.com/32e50971f32bcd21be8540758efe9aac0ffafcd9
Cr-Commit-Position: refs/heads/master@{#429669}

[tapted, 2016-11-04 05:12:50]

A revert of this CL (patchset #4 id:120001) has been created in
https://codereview.chromium.org/2472323002/ by tapted@chromium.org.

The reason for reverting is: Suspected for
drag-over-iframe-invalid-source-crash.html  failure on WebKit Linux Precise Leak
Starts
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
Error like
({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,23],"numberOfLiveResources":[0,1]}).