[RemotePlayback API] Resolve/reject prompt() properly when the element is 'connected'.

third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/remoteplayback/RemotePlayback.h"
 
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
 #include "bindings/core/v8/V8BindingForTesting.h"
 #include "bindings/modules/v8/RemotePlaybackAvailabilityCallback.h"
 #include "core/dom/DocumentUserGestureToken.h"
@@ skipping 72 matching lines @@
 
   // Runs pending promises.
   v8::MicrotasksScope::PerformCheckpoint(scope.isolate());
 
   // Verify mock expectations explicitly as the mock objects are garbage
   // collected.
   ::testing::Mock::VerifyAndClear(resolve);
   ::testing::Mock::VerifyAndClear(reject);
 }
 
+TEST_F(RemotePlaybackTest, PromptConnectedRejectsWhenCancelled) {
+  V8TestingScope scope;
+
+  auto pageHolder = DummyPageHolder::create();
+
+  HTMLMediaElement* element = HTMLVideoElement::create(pageHolder->document());
+  RemotePlayback* remotePlayback =
+      HTMLMediaElementRemotePlayback::remote(scope.getScriptState(), *element);
+
+  auto resolve = MockFunction::create(scope.getScriptState());
+  auto reject = MockFunction::create(scope.getScriptState());
+
+  EXPECT_CALL(*resolve, call(::testing::_)).Times(0);
+  EXPECT_CALL(*reject, call(::testing::_)).Times(1);
+
+  setState(remotePlayback, WebRemotePlaybackState::Connected);
+
+  UserGestureIndicator indicator(DocumentUserGestureToken::create(
+      &pageHolder->document(), UserGestureToken::NewGesture));
+  remotePlayback->prompt().then(resolve->bind(), reject->bind());
+  cancelPrompt(remotePlayback);

[mlamouri (slow - plz ping), 2016/11/02 14:59:10]

This is confusing. I initially thought of a bug: why does cancelling the prompt
rejects if already connected? What do we call cancelling the prompt in this
case? Said otherwise, what would we call not cancelling the prompt?

[whywhat, 2016/11/02 21:05:00]

Cancelling the prompt is dismissing the dialog. In both cases (connected or not)
user chose not to change the state so we throw an exception. Not cancelling the
prompt means either selecting a device or choosing to stop remote playback.

+
+  // Runs pending promises.
+  v8::MicrotasksScope::PerformCheckpoint(scope.isolate());
+
+  // Verify mock expectations explicitly as the mock objects are garbage
+  // collected.
+  ::testing::Mock::VerifyAndClear(resolve);
+  ::testing::Mock::VerifyAndClear(reject);
+}
+
+TEST_F(RemotePlaybackTest, PromptConnectedResolvesWhenDisconnected) {
+  V8TestingScope scope;
+
+  auto pageHolder = DummyPageHolder::create();
+
+  HTMLMediaElement* element = HTMLVideoElement::create(pageHolder->document());
+  RemotePlayback* remotePlayback =
+      HTMLMediaElementRemotePlayback::remote(scope.getScriptState(), *element);
+
+  auto resolve = MockFunction::create(scope.getScriptState());
+  auto reject = MockFunction::create(scope.getScriptState());
+
+  EXPECT_CALL(*resolve, call(::testing::_)).Times(1);
+  EXPECT_CALL(*reject, call(::testing::_)).Times(0);
+
+  setState(remotePlayback, WebRemotePlaybackState::Connected);
+
+  UserGestureIndicator indicator(DocumentUserGestureToken::create(
+      &pageHolder->document(), UserGestureToken::NewGesture));
+  remotePlayback->prompt().then(resolve->bind(), reject->bind());
+
+  setState(remotePlayback, WebRemotePlaybackState::Disconnected);
+
+  // Runs pending promises.
+  v8::MicrotasksScope::PerformCheckpoint(scope.isolate());
+
+  // Verify mock expectations explicitly as the mock objects are garbage
+  // collected.
+  ::testing::Mock::VerifyAndClear(resolve);
+  ::testing::Mock::VerifyAndClear(reject);
+}
+
 TEST_F(RemotePlaybackTest, StateChangeEvents) {
   V8TestingScope scope;
 
   auto pageHolder = DummyPageHolder::create();
 
   HTMLMediaElement* element = HTMLVideoElement::create(pageHolder->document());
   RemotePlayback* remotePlayback =
       HTMLMediaElementRemotePlayback::remote(scope.getScriptState(), *element);
 
   auto connectingHandler = new ::testing::StrictMock<MockEventListener>();
@@ skipping 93 matching lines @@
   v8::MicrotasksScope::PerformCheckpoint(scope.isolate());
 
   // Verify mock expectations explicitly as the mock objects are garbage
   // collected.
   ::testing::Mock::VerifyAndClear(resolve);
   ::testing::Mock::VerifyAndClear(reject);
   ::testing::Mock::VerifyAndClear(callbackFunction);
 }
 
 }  // namespace blink