Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2469853003: Revert of Use a standard message box for DesktopCastingWarningView. (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
Reviewers:
msw, Daniel Erat, Evan Stade
CC:
chromium-reviews, kalyank, sadrul, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use a standard message box for DesktopCastingWarningView. (patchset #5 id:80001 of https://codereview.chromium.org/2441403003/ ) Reason for revert: Speculative revert for flaky interactive_ui_tests on Mac10.10 Tests. See crbug.com/661550. Original issue's description: > Use a standard message box for DesktopCastingWarningView. > > This is even simpler than what I did for TeleportWarningView, which > means I should probably go back and re-rewrite that one. > > BUG=658410 > > Committed: https://crrev.com/5f1173f1e5a5678cc6c7cc9046939447398eaf19 > Cr-Commit-Position: refs/heads/master@{#428440} TBR=derat@chromium.org,msw@chromium.org,estade@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=658410, 661550 Committed: https://crrev.com/bca985a76bd8a84c1580e09cc4c621b499e2530b Cr-Commit-Position: refs/heads/master@{#429256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -71 lines) Patch
M chrome/browser/ui/ash/multi_user/user_switch_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/user_switch_util.cc View 2 chunks +168 lines, -16 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc View 3 chunks +11 lines, -20 lines 0 comments Download
M chrome/browser/ui/cocoa/simple_message_box_mac.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/simple_message_box.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/simple_message_box_views.cc View 4 chunks +0 lines, -16 lines 0 comments Download
M components/constrained_window/constrained_window_views.cc View 5 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kjellander_chromium
Created Revert of Use a standard message box for DesktopCastingWarningView.
4 years, 1 month ago (2016-11-02 11:57:26 UTC) #1
kjellander_chromium
4 years, 1 month ago (2016-11-02 11:57:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469853003/1
4 years, 1 month ago (2016-11-02 11:58:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 12:35:12 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bca985a76bd8a84c1580e09cc4c621b499e2530b Cr-Commit-Position: refs/heads/master@{#429256}
4 years, 1 month ago (2016-11-02 12:36:40 UTC) #9
kjellander_chromium
4 years, 1 month ago (2016-11-02 14:06:25 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2468873005/ by kjellander@chromium.org.

The reason for reverting is: Relanding as a new build showed the same flake:
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8584.

Powered by Google App Engine
This is Rietveld 408576698