Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 246983002: Move Gallery.app files to ui/file_manager (Closed)

Created:
6 years, 8 months ago by yoshiki
Modified:
6 years, 8 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move Gallery.app files to ui/file_manager BUG=345171 TEST=manually tested R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265231

Patch Set 1 #

Patch Set 2 : Modify third_party_files_whitelist.txt #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1452 lines) Patch
M android_webview/tools/third_party_files_whitelist.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/browser/resources/gallery/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/resources/gallery/css/gallery.css View 1 chunk +0 lines, -1381 lines 0 comments Download
D chrome/browser/resources/gallery/gallery.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/gallery/images/100/arrow_left.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/arrow_right.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/back_to_files.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/bubble_point.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/butterbar_close_button.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/cursor_crop.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/cursor_leftright.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/cursor_move.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/cursor_nwse.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/cursor_swne.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/cursor_updown.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_1up.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_1up_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_autofix.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_autofix_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_brightness.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_brightness_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_contrast.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_crop.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_crop_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_delete.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_delete_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_edit.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_edit_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_mosaic.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_mosaic_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_print.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_print_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_redo.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_redo_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_rotate.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_rotate_left.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_rotate_left_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_rotate_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_share.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_share_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_slideshow.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_slideshow_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_undo.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/icon_undo_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/slider_thumb.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/slideshow-end.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/slideshow-pause.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/100/slideshow-play.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/arrow_left.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/arrow_right.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/back_to_files.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/bubble_point.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/butterbar_close_button.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/cursor_crop.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/cursor_leftright.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/cursor_move.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/cursor_nwse.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/cursor_swne.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/cursor_updown.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_1up.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_1up_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_autofix.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_autofix_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_brightness.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_brightness_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_contrast.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_crop.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_crop_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_delete.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_delete_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_edit.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_edit_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_mosaic.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_mosaic_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_print.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_print_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_redo.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_redo_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_rotate.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_rotate_left.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_rotate_left_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_rotate_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_share.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_share_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_slideshow.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_slideshow_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_undo.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/icon_undo_selected.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/slider_thumb.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/slideshow-end.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/slideshow-pause.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/images/200/slideshow-play.png View Binary file 0 comments Download
D chrome/browser/resources/gallery/js/background.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/gallery/js/error_util.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/gallery/js/gallery.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/gallery/js/gallery_scripts.js View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/resources/gallery/js/test_util.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/gallery/manifest.json View 1 chunk +0 lines, -50 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 chunk +10 lines, -0 lines 0 comments Download
A + ui/file_manager/gallery/css/gallery.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/gallery/gallery.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/gallery/images/100/arrow_left.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/arrow_right.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/back_to_files.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/bubble_point.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/butterbar_close_button.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/cursor_crop.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/cursor_leftright.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/cursor_move.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/cursor_nwse.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/cursor_swne.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/cursor_updown.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_1up.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_1up_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_autofix.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_autofix_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_brightness.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_brightness_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_contrast.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_crop.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_crop_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_delete.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_delete_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_edit.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_edit_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_mosaic.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_mosaic_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_print.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_print_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_redo.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_redo_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_rotate.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_rotate_left.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_rotate_left_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_rotate_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_share.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_share_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_slideshow.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_slideshow_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_undo.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/icon_undo_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/slider_thumb.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/slideshow-end.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/slideshow-pause.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/slideshow-play.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/arrow_left.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/arrow_right.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/back_to_files.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/bubble_point.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/butterbar_close_button.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/cursor_crop.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/cursor_leftright.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/cursor_move.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/cursor_nwse.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/cursor_swne.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/cursor_updown.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_1up.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_1up_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_autofix.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_autofix_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_brightness.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_brightness_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_contrast.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_crop.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_crop_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_delete.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_delete_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_edit.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_edit_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_mosaic.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_mosaic_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_print.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_print_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_redo.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_redo_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_rotate.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_rotate_left.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_rotate_left_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_rotate_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_share.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_share_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_slideshow.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_slideshow_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_undo.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/icon_undo_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/slider_thumb.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/slideshow-end.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/slideshow-pause.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/slideshow-play.png View Binary file 0 comments Download
A + ui/file_manager/gallery/js/background.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/gallery/js/error_util.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/gallery/js/gallery.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/gallery/js/gallery_scripts.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/file_manager/gallery/js/test_util.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/gallery/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yoshiki
@hirono, PTAL.
6 years, 8 months ago (2014-04-22 07:23:24 UTC) #1
hirono
lgtm! Thank you for doing this.
6 years, 8 months ago (2014-04-22 07:29:02 UTC) #2
yoshiki
6 years, 8 months ago (2014-04-22 11:29:49 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as r265231.

Powered by Google App Engine
This is Rietveld 408576698