Issue 2469703002: Implement instance field guards for kernel-based FlowGraphBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2469703002: Implement instance field guards for kernel-based FlowGraphBuilder (Closed)

Created:
4 years, 1 month ago by kustermann

Modified:
4 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -7 lines)			Patch
M	runtime/vm/kernel_to_il.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/kernel_to_il.cc	View		5 chunks	+30 lines, -6 lines	0 comments	Download
M	tests/language/language_kernel.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Vyacheslav Egorov (Google)

LGTM Run tests/language/vm/optimized_guarded_field_test.dart

4 years, 1 month ago (2016-11-01 14:27:01 UTC) #3

kustermann

4 years, 1 month ago (2016-11-01 15:09:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
61c0467d41291b6a32315751c557656b6c17fdd0 (presubmit successful).