Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2469693002: Reduce CSSStyleSheet size by moving bool member. (Closed)

Created:
4 years, 1 month ago by rune
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce CSSStyleSheet size by moving bool member. Grouping bool members together saved 8 bytes from 120 to 112 on 64 bit Linux. Also started using class initializers, removed unnecessary nullptr initialization of Member<>, and a 0 -> nullptr. R=mstensho@opera.com Committed: https://crrev.com/1c9430ee698accdaf073de095b45e6a9b00cd8a4 Cr-Commit-Position: refs/heads/master@{#428977}

Patch Set 1 #

Patch Set 2 : Curly brace sneaked in. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M third_party/WebKit/Source/core/css/CSSStyleSheet.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
rune
ptal
4 years, 1 month ago (2016-11-01 09:55:07 UTC) #3
mstensho (USE GERRIT)
lgtm
4 years, 1 month ago (2016-11-01 10:00:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469693002/20001
4 years, 1 month ago (2016-11-01 10:06:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-01 11:28:27 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 11:32:11 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c9430ee698accdaf073de095b45e6a9b00cd8a4
Cr-Commit-Position: refs/heads/master@{#428977}

Powered by Google App Engine
This is Rietveld 408576698