Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 2469683002: Emit patched_sdk in the root output directory. (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
4 years, 1 month ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Emit patched_sdk in the root output directory. Previously it was emitted in the directory used for intermediate files, which is build system specific. test.py script needs to locate patched_sdk thus its location must be aligned between build systems. Use checked in SDK if available and fallback on dart_boostrap if not available to speed up Debug builds BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/d96c11fcddc6309776b3dc74bc892151784fac97

Patch Set 1 #

Total comments: 1

Patch Set 2 : Emit patched_sdk in the root output directory. #

Total comments: 1

Patch Set 3 : Martin's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -124 lines) Patch
M runtime/vm/BUILD.gn View 1 chunk +115 lines, -117 lines 0 comments Download
M runtime/vm/vm.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/patch_sdk.py View 1 2 2 chunks +21 lines, -4 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Vyacheslav Egorov (Google)
PTAL https://codereview.chromium.org/2469683002/diff/1/runtime/vm/BUILD.gn File runtime/vm/BUILD.gn (right): https://codereview.chromium.org/2469683002/diff/1/runtime/vm/BUILD.gn#newcode444 runtime/vm/BUILD.gn:444: patched_sdk_dir = "$root_out_dir/patched_sdk" This is the only line ...
4 years, 1 month ago (2016-11-01 09:05:39 UTC) #2
kustermann
lgtm
4 years, 1 month ago (2016-11-01 09:22:20 UTC) #3
kustermann
lgtm https://codereview.chromium.org/2469683002/diff/20001/tools/patch_sdk.py File tools/patch_sdk.py (right): https://codereview.chromium.org/2469683002/diff/20001/tools/patch_sdk.py#newcode37 tools/patch_sdk.py:37: 'bin', 'dart') utils.CheckedInSdkExecutable()
4 years, 1 month ago (2016-11-01 16:26:01 UTC) #5
Vyacheslav Egorov (Google)
4 years, 1 month ago (2016-11-01 16:34:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d96c11fcddc6309776b3dc74bc892151784fac97 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698