content/browser/loader/url_loader_factory_impl_unittest.cc - Issue 2469673002: Invalidate WeakPtrs of ResourceMessageFilter on channel shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/url_loader_factory_impl_unittest.cc

Issue 2469673002: Invalidate WeakPtrs of ResourceMessageFilter on channel shutdown (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/url_loader_factory_impl_unittest.cc

diff --git a/content/browser/loader/url_loader_factory_impl_unittest.cc b/content/browser/loader/url_loader_factory_impl_unittest.cc

index 5a5be02809c71afe315a4470df4155cede8cc127..fb13b2cc69eb3f38467a22211533b664110f7a11 100644

--- a/content/browser/loader/url_loader_factory_impl_unittest.cc

+++ b/content/browser/loader/url_loader_factory_impl_unittest.cc

@@ -107,6 +107,7 @@ class URLLoaderFactoryImplTest : public ::testing::TestWithParam<size_t> {

rdh_.SetDelegate(nullptr);

net::URLRequestFilter::GetInstance()->ClearHandlers();

+ resource_message_filter_->OnChannelClosing();

rdh_.CancelRequestsForProcess(resource_message_filter_->child_id());

base::RunLoop().RunUntilIdle();

MojoAsyncResourceHandler::SetAllocationSizeForTesting(