Fix incorrect usage of std::is_heap in blink::scheduler::IntrusiveHeap.

Fix incorrect usage of std::is_heap in blink::scheduler::IntrusiveHeap.

IntrusiveHeap uses std::is_heap in a DCHECK, but it uses a comparator
function that isn't irreflexive (the comparator is like <, but it should
be like <=). This CL makes the (super simple fix) and adds the necessary
plumbing for IntrusiveHeap's comparator to be unit-tested.

BUG=661080
Committed: https://crrev.com/b32830fb14c0a6c36b2735089fdb3a2ce26106e0
Cr-Commit-Position: refs/heads/master@{#429026}

[pwnall, 2016-11-01 06:59:37]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 07:00:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2016-11-01 07:01:33]

pwnall@chromium.org changed reviewers:
+ alexclarke@chromium.org

[pwnall, 2016-11-01 07:01:34]

PTAL?

FWIW, I checked the irreflexive requirement against C++ 11 (not the ISO
standard, but N3242). It's documented in 25.4 [alg.sorting], in case you want to
double-check my work.

[commit-bot: I haz the power, 2016-11-01 07:38:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 07:38:32]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[pwnall, 2016-11-01 08:45:00]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 08:45:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2016-11-01 10:11:57]

lgtm

[commit-bot: I haz the power, 2016-11-01 12:22:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 12:22:05]

Dry run: This issue passed the CQ dry run.

[pwnall, 2016-11-01 16:47:33]

The CQ bit was checked by pwnall@chromium.org

[pwnall, 2016-11-01 16:47:47]

On 2016/11/01 10:11:57, alex clarke wrote:
> lgtm

Thank you for the quick turnaround!

[commit-bot: I haz the power, 2016-11-01 16:48:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 16:53:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-01 17:22:36]

Description was changed from

==========
Fix incorrect usage of std::is_heap in blink::scheduler::IntrusiveHeap.

IntrusiveHeap uses std::is_heap in a DCHECK, but it uses a comparator
function that isn't irreflexive (the comparator is like <, but it should
be like <=). This CL makes the (super simple fix) and adds the necessary
plumbing for IntrusiveHeap's comparator to be unit-tested.

BUG=661080
==========

to

==========
Fix incorrect usage of std::is_heap in blink::scheduler::IntrusiveHeap.

IntrusiveHeap uses std::is_heap in a DCHECK, but it uses a comparator
function that isn't irreflexive (the comparator is like <, but it should
be like <=). This CL makes the (super simple fix) and adds the necessary
plumbing for IntrusiveHeap's comparator to be unit-tested.

BUG=661080

Committed: https://crrev.com/b32830fb14c0a6c36b2735089fdb3a2ce26106e0
Cr-Commit-Position: refs/heads/master@{#429026}
==========

[commit-bot: I haz the power, 2016-11-01 17:22:37]

Patchset 2 (id:??) landed as
https://crrev.com/b32830fb14c0a6c36b2735089fdb3a2ce26106e0
Cr-Commit-Position: refs/heads/master@{#429026}