Issue 246963005: Change ErrorNode to masquerade as a null literal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246963005: Change ErrorNode to masquerade as a null literal. (Closed)

Created:
6 years, 8 months ago by ahe

Modified:
6 years, 8 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Change ErrorNode to masquerade as a null literal. BUG=http://dartbug.com/18072 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=35388

Patch Set 2 : Merged with r35372 #

Patch Set 3 : Merged with r35381 and exception for MessageKind.UNMATCHED_TOKEN. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -9 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/tree/nodes.dart	View		1 chunk	+3 lines, -5 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/warnings.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js/message_kind_helper.dart	View	1 2	3 chunks	+42 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

https://codereview.chromium.org/246963005/diff/1/dart/sdk/lib/_internal/compiler/implementation/warnings.dart File dart/sdk/lib/_internal/compiler/implementation/warnings.dart (right): https://codereview.chromium.org/246963005/diff/1/dart/sdk/lib/_internal/compiler/implementation/warnings.dart#newcode1500 dart/sdk/lib/_internal/compiler/implementation/warnings.dart:1500: main() => new Class().method(); Gets rid of a warning. ...

6 years, 8 months ago (2014-04-22 14:06:20 UTC) #1