X87: [turbofan] Support variable size argument removal in TF-generated functions.

X87: [turbofan] Support variable size argument removal in TF-generated functions.

  port 5319b50c853c4213d825aa7cf620fde5d827f7eb (r40678)

  original commit message:
  This is preparation for using TF to create builtins that handle variable number of
  arguments and have to remove these arguments dynamically from the stack upon
  return.

  The gist of the changes:
  - Added a second argument to the Return node which specifies the number of stack
    slots to pop upon return in addition to those specified by the Linkage of the
    compiled function.
  - Removed Tail -> Non-Tail fallback in the instruction selector. Since TF now should
    handles all tail-call cases except where the return value type differs, this fallback
    was not really useful and in fact caused unexpected behavior with variable
    sized argument popping, since it wasn't possible to materialize a Return node
    with the right pop count from the TailCall without additional context.
  - Modified existing Return generation to pass a constant zero as the additional
    pop argument since the variable pop functionality

BUG=

Committed: https://crrev.com/c1753f5c3d8b4c498cb3fa35e0d5c5b79f353c9b
Cr-Commit-Position: refs/heads/master@{#40684}

[zhengxing.li, 2016-11-01 03:43:23]

zhengxing.li@intel.com changed reviewers:
+ chunyang.dai@intel.com, danno@chromium.org, weiliang.lin@intel.com

[zhengxing.li, 2016-11-01 03:43:24]

PTAL, thanks!

[Weiliang, 2016-11-01 06:33:47]

lgtm

[zhengxing.li, 2016-11-01 06:34:43]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-11-01 06:34:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 06:55:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:18:40]

Description was changed from

==========
X87: [turbofan] Support variable size argument removal in TF-generated
functions.

  port 5319b50c853c4213d825aa7cf620fde5d827f7eb (r40678)

  original commit message:
  This is preparation for using TF to create builtins that handle variable
number of
  arguments and have to remove these arguments dynamically from the stack upon
  return.

  The gist of the changes:
  - Added a second argument to the Return node which specifies the number of
stack
    slots to pop upon return in addition to those specified by the Linkage of
the
    compiled function.
  - Removed Tail -> Non-Tail fallback in the instruction selector. Since TF now
should
    handles all tail-call cases except where the return value type differs, this
fallback
    was not really useful and in fact caused unexpected behavior with variable
    sized argument popping, since it wasn't possible to materialize a Return
node
    with the right pop count from the TailCall without additional context.
  - Modified existing Return generation to pass a constant zero as the
additional
    pop argument since the variable pop functionality

BUG=
==========

to

==========
X87: [turbofan] Support variable size argument removal in TF-generated
functions.

  port 5319b50c853c4213d825aa7cf620fde5d827f7eb (r40678)

  original commit message:
  This is preparation for using TF to create builtins that handle variable
number of
  arguments and have to remove these arguments dynamically from the stack upon
  return.

  The gist of the changes:
  - Added a second argument to the Return node which specifies the number of
stack
    slots to pop upon return in addition to those specified by the Linkage of
the
    compiled function.
  - Removed Tail -> Non-Tail fallback in the instruction selector. Since TF now
should
    handles all tail-call cases except where the return value type differs, this
fallback
    was not really useful and in fact caused unexpected behavior with variable
    sized argument popping, since it wasn't possible to materialize a Return
node
    with the right pop count from the TailCall without additional context.
  - Modified existing Return generation to pass a constant zero as the
additional
    pop argument since the variable pop functionality

BUG=

Committed: https://crrev.com/c1753f5c3d8b4c498cb3fa35e0d5c5b79f353c9b
Cr-Commit-Position: refs/heads/master@{#40684}
==========

[commit-bot: I haz the power, 2016-11-17 22:18:41]

Patchset 1 (id:??) landed as
https://crrev.com/c1753f5c3d8b4c498cb3fa35e0d5c5b79f353c9b
Cr-Commit-Position: refs/heads/master@{#40684}