Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2469503003:
Enable shared memory for field trials (Closed)
|
Created:
4 years, 1 month ago by lawrencewu Modified:
4 years, 1 month ago Reviewers:
Alexei Svitkine (slow) CC:
chromium-reviews, asvitkine+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable shared memory for field trials
This turns on the flag for using shared memory to share field trials between processes. For more context, see:
The design document: go/share-field-trials
The related previous CLs:
https://codereview.chromium.org/2365273004/
https://codereview.chromium.org/2412113002/
https://codereview.chromium.org/2449143002/
https://codereview.chromium.org/2453093002/
https://codereview.chromium.org/2449783007/
https://codereview.chromium.org/2456723004/
https://codereview.chromium.org/2453933004/
BUG=131632
Committed: https://crrev.com/4446189e8148980b9a245cb1157e8a695bac35d1
Cr-Commit-Position: refs/heads/master@{#429042}
Patch Set 1 #Patch Set 2 : rebase-update #
Messages
Total messages: 25 (17 generated)
The CQ bit was checked by lawrencewu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
lawrencewu@chromium.org changed reviewers: + asvitkine@chromium.org
Turns the flag for using shared memory on.
Description was changed from ========== Enable shared memory for field trials BUG=131632 ========== to ========== Enable shared memory for field trials This turns on the flag for using shared memory to share field trials between processes. For more context, see: The design document: https://docs.google.com/document/d/1CTFOpOpbqnOTzo_gCuSyqDur0AeY2X_LFayylN_oH... The related previous CLs: https://codereview.chromium.org/2365273004/ https://codereview.chromium.org/2412113002/ https://codereview.chromium.org/2449143002/ https://codereview.chromium.org/2453093002/ https://codereview.chromium.org/2449783007/ https://codereview.chromium.org/2456723004/ https://codereview.chromium.org/2453933004/ BUG=131632 ==========
Description was changed from ========== Enable shared memory for field trials This turns on the flag for using shared memory to share field trials between processes. For more context, see: The design document: https://docs.google.com/document/d/1CTFOpOpbqnOTzo_gCuSyqDur0AeY2X_LFayylN_oH... The related previous CLs: https://codereview.chromium.org/2365273004/ https://codereview.chromium.org/2412113002/ https://codereview.chromium.org/2449143002/ https://codereview.chromium.org/2453093002/ https://codereview.chromium.org/2449783007/ https://codereview.chromium.org/2456723004/ https://codereview.chromium.org/2453933004/ BUG=131632 ========== to ========== Enable shared memory for field trials This turns on the flag for using shared memory to share field trials between processes. For more context, see: The design document: go/share-field-trials The related previous CLs: https://codereview.chromium.org/2365273004/ https://codereview.chromium.org/2412113002/ https://codereview.chromium.org/2449143002/ https://codereview.chromium.org/2453093002/ https://codereview.chromium.org/2449783007/ https://codereview.chromium.org/2456723004/ https://codereview.chromium.org/2453933004/ BUG=131632 ==========
lgtm
The CQ bit was checked by lawrencewu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by lawrencewu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lawrencewu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/2469503003/#ps20001 (title: "rebase-update")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable shared memory for field trials This turns on the flag for using shared memory to share field trials between processes. For more context, see: The design document: go/share-field-trials The related previous CLs: https://codereview.chromium.org/2365273004/ https://codereview.chromium.org/2412113002/ https://codereview.chromium.org/2449143002/ https://codereview.chromium.org/2453093002/ https://codereview.chromium.org/2449783007/ https://codereview.chromium.org/2456723004/ https://codereview.chromium.org/2453933004/ BUG=131632 ========== to ========== Enable shared memory for field trials This turns on the flag for using shared memory to share field trials between processes. For more context, see: The design document: go/share-field-trials The related previous CLs: https://codereview.chromium.org/2365273004/ https://codereview.chromium.org/2412113002/ https://codereview.chromium.org/2449143002/ https://codereview.chromium.org/2453093002/ https://codereview.chromium.org/2449783007/ https://codereview.chromium.org/2456723004/ https://codereview.chromium.org/2453933004/ BUG=131632 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Enable shared memory for field trials This turns on the flag for using shared memory to share field trials between processes. For more context, see: The design document: go/share-field-trials The related previous CLs: https://codereview.chromium.org/2365273004/ https://codereview.chromium.org/2412113002/ https://codereview.chromium.org/2449143002/ https://codereview.chromium.org/2453093002/ https://codereview.chromium.org/2449783007/ https://codereview.chromium.org/2456723004/ https://codereview.chromium.org/2453933004/ BUG=131632 ========== to ========== Enable shared memory for field trials This turns on the flag for using shared memory to share field trials between processes. For more context, see: The design document: go/share-field-trials The related previous CLs: https://codereview.chromium.org/2365273004/ https://codereview.chromium.org/2412113002/ https://codereview.chromium.org/2449143002/ https://codereview.chromium.org/2453093002/ https://codereview.chromium.org/2449783007/ https://codereview.chromium.org/2456723004/ https://codereview.chromium.org/2453933004/ BUG=131632 Committed: https://crrev.com/4446189e8148980b9a245cb1157e8a695bac35d1 Cr-Commit-Position: refs/heads/master@{#429042} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4446189e8148980b9a245cb1157e8a695bac35d1 Cr-Commit-Position: refs/heads/master@{#429042}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2471493004/ by creis@chromium.org. The reason for reverting is: Appears to have caused renderer processes to lose knowledge of Finch trials, which led to a large spike in CreateFrame crashes for OOPIFs in https://crbug.com/661617.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
