Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2469453002: Send highlight and navigation notifications on result. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Send highlight and navigation notifications on result. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4d8ceb01a12bcbf39a3653d7253dd69d32e871cc

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -16 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 4 chunks +23 lines, -16 lines 2 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 1 month ago (2016-10-31 17:27:24 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2469453002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/2469453002/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode1109 pkg/analysis_server/lib/src/analysis_server.dart:1109: // TODO(scheglov) implement for the new analysis driver ...
4 years, 1 month ago (2016-10-31 17:56:00 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 4d8ceb01a12bcbf39a3653d7253dd69d32e871cc (presubmit successful).
4 years, 1 month ago (2016-10-31 18:04:55 UTC) #4
scheglov
4 years, 1 month ago (2016-10-31 18:05:30 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/2469453002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/2469453002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:1109: // TODO(scheglov)
implement for the new analysis driver
On 2016/10/31 17:56:00, Brian Wilkerson wrote:
> Is there still more to do, or should the TODO be removed? If the former,
please
> update the TODO to be more specific.

Done.

Powered by Google App Engine
This is Rietveld 408576698