Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2469433003: Reland of move stl_util's deletion function use from components/invalidation/. (Closed)

Created:
4 years, 1 month ago by xidachen
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of move stl_util's deletion function use from components/invalidation/. (patchset #1 id:1 of https://codereview.chromium.org/2464903003/ ) Reason for revert: Not the cause of the failure. Original issue's description: > Revert of Remove stl_util's deletion function use from components/invalidation/. (patchset #2 id:20001 of https://codereview.chromium.org/2465733002/ ) > > Reason for revert: > suspect causing failure here: > https://build.chromium.org/p/chromium.mac/builders/ios-simulator/builds/6991 > > Original issue's description: > > Remove stl_util's deletion function use from components/invalidation/. > > > > BUG=555865 > > > > Committed: https://crrev.com/89df5e0546823b3cfd7721343bf71a77b2f60d9d > > Cr-Commit-Position: refs/heads/master@{#428714} > > TBR=dcheng@chromium.org,avi@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=555865 TBR=dcheng@chromium.org,avi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=555865 Committed: https://crrev.com/6a57860ee4c30bdcb9062d6a3b46aa565411ab39 Cr-Commit-Position: refs/heads/master@{#428748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -51 lines) Patch
M components/invalidation/impl/registration_manager.h View 3 chunks +5 lines, -5 lines 0 comments Download
M components/invalidation/impl/registration_manager.cc View 13 chunks +20 lines, -29 lines 0 comments Download
M components/invalidation/impl/sync_system_resources.h View 2 chunks +3 lines, -5 lines 0 comments Download
M components/invalidation/impl/sync_system_resources.cc View 9 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
xidachen
Created Reland of move stl_util's deletion function use from components/invalidation/.
4 years, 1 month ago (2016-10-31 17:07:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469433003/1
4 years, 1 month ago (2016-10-31 17:07:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 17:08:43 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 17:16:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a57860ee4c30bdcb9062d6a3b46aa565411ab39
Cr-Commit-Position: refs/heads/master@{#428748}

Powered by Google App Engine
This is Rietveld 408576698