Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/test/data/webui/settings/settings_ui_browsertest.js

Issue 2469393004: MD Settings: Preserve search URL param in subpages. (Closed)
Patch Set: Fix test. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/settings_ui_browsertest.js
diff --git a/chrome/test/data/webui/settings/settings_ui_browsertest.js b/chrome/test/data/webui/settings/settings_ui_browsertest.js
index c3d4fbfea931e56efc9a0097d35f3ca7d7ff2141..03bb6639d78b9e6661c442be26262a65173acf2b 100644
--- a/chrome/test/data/webui/settings/settings_ui_browsertest.js
+++ b/chrome/test/data/webui/settings/settings_ui_browsertest.js
@@ -116,20 +116,22 @@ TEST_F('SettingsUIBrowserTest', 'MAYBE_All', function() {
toolbar = /** @type {!CrToolbarElement} */ (ui.$$('cr-toolbar'));
var searchField = /** @type {CrToolbarSearchFieldElement} */ (
toolbar.getSearchField());
+ assertEquals('', searchField.getSearchInput().bindValue);
var query = 'foo';
settings.navigateTo(
settings.Route.BASIC, new URLSearchParams(`search=${query}`));
assertEquals(query, searchField.getSearchInput().bindValue);
-
- settings.navigateTo(settings.Route.BASIC);
- assertEquals('', searchField.getSearchInput().bindValue);
});
test('search box initiated search propagates to URL', function() {
- assertFalse(settings.getQueryParameters().has('search'));
var searchField = /** @type {CrToolbarSearchFieldElement} */ (
toolbar.getSearchField());
+
+ settings.navigateTo(settings.Route.BASIC, null, false);
dschuyler 2016/11/09 22:52:13 What are null, false representing here?
+ assertEquals('', searchField.getSearchInput().bindValue);
+ assertFalse(settings.getQueryParameters().has('search'));
+
var value = 'GOOG';
searchField.setValue(value);
assertEquals(value, settings.getQueryParameters().get('search'));

Powered by Google App Engine
This is Rietveld 408576698