Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4900)

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 2469393004: MD Settings: Preserve search URL param in subpages. (Closed)
Patch Set: Update params. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_ui/settings_ui.js
diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.js b/chrome/browser/resources/settings/settings_ui/settings_ui.js
index a3778e74496f8737db93d06a044af5313ab530bf..cdbb91f68f782c2de528e0c7057a156a2fcb6d85 100644
--- a/chrome/browser/resources/settings/settings_ui/settings_ui.js
+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.js
@@ -122,18 +122,6 @@ Polymer({
/** @param {!settings.Route} route */
currentRouteChanged: function(route) {
- // New searches always take place on the BASIC route. Navigations into
- // subpages are either non-searches, or continuations of an existing search.
- //
- // TODO(dpapad): Address corner-case where the user:
- // 1) Visits a subpage first.
- // 2) Triggers a search.
- // 3) Clicks the "back" button.
- // Currently nothing happens. Should clear search results and navigate to
- // the subpage instead.
- if (route.isSubpage())
- return;
-
var urlSearchQuery = settings.getQueryParameters().get('search') || '';
if (urlSearchQuery == this.lastSearchQuery_)
return;

Powered by Google App Engine
This is Rietveld 408576698