Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6588)

Unified Diff: chrome/test/data/webui/settings/settings_menu_test.js

Issue 2469393004: MD Settings: Preserve search URL param in subpages. (Closed)
Patch Set: Function params nit. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/settings_menu_test.js
diff --git a/chrome/test/data/webui/settings/settings_menu_test.js b/chrome/test/data/webui/settings/settings_menu_test.js
index 2d0adbef5da96b49e00d28d6e495859aff3602a9..6381eb58249fd14dc60356c1b91c307372321339 100644
--- a/chrome/test/data/webui/settings/settings_menu_test.js
+++ b/chrome/test/data/webui/settings/settings_menu_test.js
@@ -67,6 +67,18 @@ cr.define('settings_menu', function() {
assertEquals('/reset',
advancedPage.querySelector('paper-menu').selected);
});
+
+ // Test that navigating via the paper menu always clears the current
+ // search URL parameter.
+ test('clearsUrlSearchParam', function() {
+ var urlParams = new URLSearchParams('search=foo');
+ settings.navigateTo(settings.Route.BASIC, urlParams);
+ assertEquals(
+ urlParams.toString(),
+ settings.getQueryParameters().toString());
+ MockInteractions.tap(settingsMenu.$.people);
+ assertEquals('', settings.getQueryParameters().toString());
+ });
});
}
« no previous file with comments | « chrome/test/data/webui/settings/route_tests.js ('k') | chrome/test/data/webui/settings/settings_ui_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698