chrome/browser/resources/settings/settings_menu/settings_menu.js - Issue 2469393004: MD Settings: Preserve search URL param in subpages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.js

Issue 2469393004: MD Settings: Preserve search URL param in subpages. (Closed)

Patch Set: Function params nit. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_menu/settings_menu.js

diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js

index fb672628d46bb92741caafc2dc76d93df4dba12f..d40439842da148e8198c2b9f999b93573fa1bda3 100644

--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js

+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js

@@ -75,7 +75,8 @@ Polymer({

openPage_: function(event) {

var route = settings.getRouteForPath(event.currentTarget.dataset.path);

assert(route, 'settings-menu has an an entry with an invalid path');

- settings.navigateTo(route);

+ settings.navigateTo(

+ route, /* dynamicParams */ null, /* removeSearch */ true);

/**