MD Settings: Preserve search URL param in subpages.

chrome/test/data/webui/settings/settings_ui_browsertest.js

Index: chrome/test/data/webui/settings/settings_ui_browsertest.js
diff --git a/chrome/test/data/webui/settings/settings_ui_browsertest.js b/chrome/test/data/webui/settings/settings_ui_browsertest.js
index c3d4fbfea931e56efc9a0097d35f3ca7d7ff2141..3271a082d9ebdef3c280e5e3c03e7b6b8cac8954 100644
--- a/chrome/test/data/webui/settings/settings_ui_browsertest.js
+++ b/chrome/test/data/webui/settings/settings_ui_browsertest.js
@@ -116,20 +116,24 @@ TEST_F('SettingsUIBrowserTest', 'MAYBE_All', function() {
       toolbar = /** @type {!CrToolbarElement} */ (ui.$$('cr-toolbar'));
       var searchField = /** @type {CrToolbarSearchFieldElement} */ (
           toolbar.getSearchField());
+      assertEquals('', searchField.getSearchInput().bindValue);
 
       var query = 'foo';
       settings.navigateTo(
           settings.Route.BASIC, new URLSearchParams(`search=${query}`));
       assertEquals(query, searchField.getSearchInput().bindValue);
-
-      settings.navigateTo(settings.Route.BASIC);
-      assertEquals('', searchField.getSearchInput().bindValue);
     });
 
     test('search box initiated search propagates to URL', function() {
-      assertFalse(settings.getQueryParameters().has('search'));
       var searchField = /** @type {CrToolbarSearchFieldElement} */ (
           toolbar.getSearchField());
+
+      settings.navigateTo(
+          settings.Route.BASIC,
+          /* dynamicParams */ null, /* removeSearch */ true);

[dschuyler, 2016/11/09 23:45:36]

optional:
I've gotten the advice to fill the prior line before wrapping.
I'm passing that along as a suggestion, though I don't recall 
that being in the style guide, so this is optional.

settings.navigateTo(settings.Route.BASIC, /* dynamicParams */ null,
    /* removeSearch */ true);

[dpapad, 2016/11/09 23:52:09]

This conflicts with this guideline (from the C++ guide, which JS inherits from,
or used to inherit from).

"If the arguments do not all fit on one line, they should be broken up onto
multiple lines, with each subsequent line aligned with the first argument."
https://google.github.io/styleguide/cppguide.html#Function_Calls

In other words the 1st parameter in each line should start at the same column.
fooMethod(bar,
          baz);
OR
fooMethod(
    bar,
    baz);

The latter has a slight advantage, that renaming the method later can be
automated with a script, without having to adjust the 2nd line's indentation.

+      assertEquals('', searchField.getSearchInput().bindValue);
+      assertFalse(settings.getQueryParameters().has('search'));
+
       var value = 'GOOG';
       searchField.setValue(value);
       assertEquals(value, settings.getQueryParameters().get('search'));